From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mx35_3ds: remove unnecessary USB OTG init flag
Date: Sat, 24 Feb 2018 17:08:21 +0800 [thread overview]
Message-ID: <20180224090818.GP3217@dragon> (raw)
In-Reply-To: <1519251463-12318-1-git-send-email-martin@kaiser.cx>
On Wed, Feb 21, 2018 at 11:17:43PM +0100, Martin Kaiser wrote:
> The platform-specific init function for the USB OTG port,
> mx35_3ds_otg_init(), sets the MXC_EHCI_INTERNAL_PHY flag.
>
> This flag is applicable only to the host port, not to the OTG port. It's
> ignored by mx35_initialize_usb_hw() when the OTG port is initialized.
>
> Remove the flag to make it clear what is actually configured.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
We do not take any patch on legacy board files, unless it fixes some
real problem.
Shawn
> ---
> arch/arm/mach-imx/mach-mx35_3ds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/mach-mx35_3ds.c b/arch/arm/mach-imx/mach-mx35_3ds.c
> index 1c33a6c..f1963f2 100644
> --- a/arch/arm/mach-imx/mach-mx35_3ds.c
> +++ b/arch/arm/mach-imx/mach-mx35_3ds.c
> @@ -407,7 +407,7 @@ static void __init imx35_3ds_init_mc13892(void)
>
> static int mx35_3ds_otg_init(struct platform_device *pdev)
> {
> - return mx35_initialize_usb_hw(pdev->id, MXC_EHCI_INTERNAL_PHY);
> + return mx35_initialize_usb_hw(pdev->id, 0);
> }
>
> /* OTG config */
> --
> 2.1.4
>
prev parent reply other threads:[~2018-02-24 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 22:17 [PATCH] ARM: mx35_3ds: remove unnecessary USB OTG init flag Martin Kaiser
2018-02-24 9:08 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224090818.GP3217@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox