From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl
Date: Sat, 24 Feb 2018 13:11:37 +0000 [thread overview]
Message-ID: <20180224131137.1b2a79f3@archlinux> (raw)
In-Reply-To: <7e40cdfc-8d9f-ccfb-f3fd-8d639a87d5b0@st.com>
On Fri, 23 Feb 2018 14:47:36 +0100
Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote:
> Hello,
>
> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
I'm feeling conservative today so will be wanting a devicetree
maintainer ack for this one..
Jonathan
>
> Regards,
> Arnaud
>
> On 02/23/2018 12:11 PM, Fabrice Gasnier wrote:
> > - Add missing pinctrl description. Support is made optional as dfsdm
> > may use internal sources (e.g. via registers)
> > - Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
> > Basically, this should be "falling edge = logic 0", not "1" that applies
> > to "MANCH_R".
> > BTW, make the description complete by describing both rising/falling
> > edges as described in reference manuals.
> >
> > Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")
> >
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> > ---
> > Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > index 911492da..ed7520d 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > @@ -32,6 +32,10 @@ Optional properties:
> > to "clock" property. Frequency must be a multiple of the rcc
> > clock frequency. If not, SPI CLKOUT frequency will not be
> > accurate.
> > +- pinctrl-names: Set to "default".
> > +- pinctrl-0: List of phandles pointing to pin configuration
> > + nodes to set pins in mode of operation for dfsdm
> > + on external pin.
> >
> > Contents of a STM32 DFSDM child nodes:
> > --------------------------------------
> > @@ -68,8 +72,8 @@ Optional properties:
> > - st,adc-channel-types: Single-ended channel input type.
> > - "SPI_R": SPI with data on rising edge (default)
> > - "SPI_F": SPI with data on falling edge
> > - - "MANCH_R": manchester codec, rising edge = logic 0
> > - - "MANCH_F": manchester codec, falling edge = logic 1
> > + - "MANCH_R": manchester codec, rising edge = logic 0, falling edge = logic 1
> > + - "MANCH_F": manchester codec, rising edge = logic 1, falling edge = logic 0
> > - st,adc-channel-clk-src: Conversion clock source.
> > - "CLKIN": external SPI clock (CLKIN x)
> > - "CLKOUT": internal SPI clock (CLKOUT) (default)
> >
next prev parent reply other threads:[~2018-02-24 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 11:11 [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl Fabrice Gasnier
2018-02-23 13:47 ` Arnaud Pouliquen
2018-02-24 13:11 ` Jonathan Cameron [this message]
2018-03-02 16:25 ` Rob Herring
2018-03-03 15:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224131137.1b2a79f3@archlinux \
--to=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).