* [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl
@ 2018-02-23 11:11 Fabrice Gasnier
2018-02-23 13:47 ` Arnaud Pouliquen
2018-03-02 16:25 ` Rob Herring
0 siblings, 2 replies; 5+ messages in thread
From: Fabrice Gasnier @ 2018-02-23 11:11 UTC (permalink / raw)
To: linux-arm-kernel
- Add missing pinctrl description. Support is made optional as dfsdm
may use internal sources (e.g. via registers)
- Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
Basically, this should be "falling edge = logic 0", not "1" that applies
to "MANCH_R".
BTW, make the description complete by describing both rising/falling
edges as described in reference manuals.
Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
index 911492da..ed7520d 100644
--- a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
+++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
@@ -32,6 +32,10 @@ Optional properties:
to "clock" property. Frequency must be a multiple of the rcc
clock frequency. If not, SPI CLKOUT frequency will not be
accurate.
+- pinctrl-names: Set to "default".
+- pinctrl-0: List of phandles pointing to pin configuration
+ nodes to set pins in mode of operation for dfsdm
+ on external pin.
Contents of a STM32 DFSDM child nodes:
--------------------------------------
@@ -68,8 +72,8 @@ Optional properties:
- st,adc-channel-types: Single-ended channel input type.
- "SPI_R": SPI with data on rising edge (default)
- "SPI_F": SPI with data on falling edge
- - "MANCH_R": manchester codec, rising edge = logic 0
- - "MANCH_F": manchester codec, falling edge = logic 1
+ - "MANCH_R": manchester codec, rising edge = logic 0, falling edge = logic 1
+ - "MANCH_F": manchester codec, rising edge = logic 1, falling edge = logic 0
- st,adc-channel-clk-src: Conversion clock source.
- "CLKIN": external SPI clock (CLKIN x)
- "CLKOUT": internal SPI clock (CLKOUT) (default)
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl
2018-02-23 11:11 [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl Fabrice Gasnier
@ 2018-02-23 13:47 ` Arnaud Pouliquen
2018-02-24 13:11 ` Jonathan Cameron
2018-03-02 16:25 ` Rob Herring
1 sibling, 1 reply; 5+ messages in thread
From: Arnaud Pouliquen @ 2018-02-23 13:47 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Regards,
Arnaud
On 02/23/2018 12:11 PM, Fabrice Gasnier wrote:
> - Add missing pinctrl description. Support is made optional as dfsdm
> may use internal sources (e.g. via registers)
> - Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
> Basically, this should be "falling edge = logic 0", not "1" that applies
> to "MANCH_R".
> BTW, make the description complete by describing both rising/falling
> edges as described in reference manuals.
>
> Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> index 911492da..ed7520d 100644
> --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> @@ -32,6 +32,10 @@ Optional properties:
> to "clock" property. Frequency must be a multiple of the rcc
> clock frequency. If not, SPI CLKOUT frequency will not be
> accurate.
> +- pinctrl-names: Set to "default".
> +- pinctrl-0: List of phandles pointing to pin configuration
> + nodes to set pins in mode of operation for dfsdm
> + on external pin.
>
> Contents of a STM32 DFSDM child nodes:
> --------------------------------------
> @@ -68,8 +72,8 @@ Optional properties:
> - st,adc-channel-types: Single-ended channel input type.
> - "SPI_R": SPI with data on rising edge (default)
> - "SPI_F": SPI with data on falling edge
> - - "MANCH_R": manchester codec, rising edge = logic 0
> - - "MANCH_F": manchester codec, falling edge = logic 1
> + - "MANCH_R": manchester codec, rising edge = logic 0, falling edge = logic 1
> + - "MANCH_F": manchester codec, rising edge = logic 1, falling edge = logic 0
> - st,adc-channel-clk-src: Conversion clock source.
> - "CLKIN": external SPI clock (CLKIN x)
> - "CLKOUT": internal SPI clock (CLKOUT) (default)
>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl
2018-02-23 13:47 ` Arnaud Pouliquen
@ 2018-02-24 13:11 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2018-02-24 13:11 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 23 Feb 2018 14:47:36 +0100
Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote:
> Hello,
>
> Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
I'm feeling conservative today so will be wanting a devicetree
maintainer ack for this one..
Jonathan
>
> Regards,
> Arnaud
>
> On 02/23/2018 12:11 PM, Fabrice Gasnier wrote:
> > - Add missing pinctrl description. Support is made optional as dfsdm
> > may use internal sources (e.g. via registers)
> > - Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
> > Basically, this should be "falling edge = logic 0", not "1" that applies
> > to "MANCH_R".
> > BTW, make the description complete by describing both rising/falling
> > edges as described in reference manuals.
> >
> > Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")
> >
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> > ---
> > Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > index 911492da..ed7520d 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt
> > @@ -32,6 +32,10 @@ Optional properties:
> > to "clock" property. Frequency must be a multiple of the rcc
> > clock frequency. If not, SPI CLKOUT frequency will not be
> > accurate.
> > +- pinctrl-names: Set to "default".
> > +- pinctrl-0: List of phandles pointing to pin configuration
> > + nodes to set pins in mode of operation for dfsdm
> > + on external pin.
> >
> > Contents of a STM32 DFSDM child nodes:
> > --------------------------------------
> > @@ -68,8 +72,8 @@ Optional properties:
> > - st,adc-channel-types: Single-ended channel input type.
> > - "SPI_R": SPI with data on rising edge (default)
> > - "SPI_F": SPI with data on falling edge
> > - - "MANCH_R": manchester codec, rising edge = logic 0
> > - - "MANCH_F": manchester codec, falling edge = logic 1
> > + - "MANCH_R": manchester codec, rising edge = logic 0, falling edge = logic 1
> > + - "MANCH_F": manchester codec, rising edge = logic 1, falling edge = logic 0
> > - st,adc-channel-clk-src: Conversion clock source.
> > - "CLKIN": external SPI clock (CLKIN x)
> > - "CLKOUT": internal SPI clock (CLKOUT) (default)
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl
2018-02-23 11:11 [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl Fabrice Gasnier
2018-02-23 13:47 ` Arnaud Pouliquen
@ 2018-03-02 16:25 ` Rob Herring
2018-03-03 15:08 ` Jonathan Cameron
1 sibling, 1 reply; 5+ messages in thread
From: Rob Herring @ 2018-03-02 16:25 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Feb 23, 2018 at 12:11:00PM +0100, Fabrice Gasnier wrote:
> - Add missing pinctrl description. Support is made optional as dfsdm
> may use internal sources (e.g. via registers)
> - Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
> Basically, this should be "falling edge = logic 0", not "1" that applies
> to "MANCH_R".
> BTW, make the description complete by describing both rising/falling
> edges as described in reference manuals.
>
> Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
> Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl
2018-03-02 16:25 ` Rob Herring
@ 2018-03-03 15:08 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2018-03-03 15:08 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, 2 Mar 2018 10:25:13 -0600
Rob Herring <robh@kernel.org> wrote:
> On Fri, Feb 23, 2018 at 12:11:00PM +0100, Fabrice Gasnier wrote:
> > - Add missing pinctrl description. Support is made optional as dfsdm
> > may use internal sources (e.g. via registers)
> > - Fix typo in IIO STM32 DFSDM filter "MANCH_F" description.
> > Basically, this should be "falling edge = logic 0", not "1" that applies
> > to "MANCH_R".
> > BTW, make the description complete by describing both rising/falling
> > edges as described in reference manuals.
> >
> > Fixes: 6c82f947fc97 ("IIO: add DT bindings for stm32 DFSDM filter")
> >
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> > ---
> > Documentation/devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.txt | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied to the togreg branch of iio.git and pushed out as testing.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-03 15:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-23 11:11 [PATCH] dt-bindings: iio: adc: stm32-dfsdm: fix types, add missing pinctrl Fabrice Gasnier
2018-02-23 13:47 ` Arnaud Pouliquen
2018-02-24 13:11 ` Jonathan Cameron
2018-03-02 16:25 ` Rob Herring
2018-03-03 15:08 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).