From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: regression v4.16 on Nokia N900:/dev/input/event6 aka AV Jack support disappeared
Date: Sat, 24 Feb 2018 22:46:17 +0100 [thread overview]
Message-ID: <20180224214617.GA22619@amd> (raw)
Hi!
In v4.16, AV jack support disappeared.
This one is suspect:
commit 7be4b5dc7ffa9499ac6ef33a5ffa9ff43f9b7057
Author: Andrew F. Davis <afd@ti.com>
Date: Wed Nov 29 11:13:59 2017 -0600
ARM: dts: omap3-n900: Fix the audio CODEC's reset pin
The correct DT property for specifying a GPIO used for reset
is "reset-gpios", fix this here.
Fixes: 14e3e295b2b9 ("ARM: dts: omap3-n900: Add TLV320AIC3X
support")
Signed-off-by: Andrew F. Davis <afd@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
How was it tested? It reverts polarity of reset pin, but
sound/soc/codecs/tlv320aic3x.c treats those as aliases:
ret = of_get_named_gpio(np, "reset-gpios", 0);
if (ret >= 0) {
aic3x->gpio_reset = ret;
} else {
ret = of_get_named_gpio(np, "gpio-reset", 0);
if (ret > 0) {
dev_warn(&i2c->dev, "Using deprecated property \"gpio-r\eset\", please update your DT");
aic3x->gpio_reset = ret;
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180224/bcfa934f/attachment-0001.sig>
next reply other threads:[~2018-02-24 21:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 21:46 Pavel Machek [this message]
2018-02-26 9:47 ` regression v4.16 on Nokia N900:/dev/input/event6 aka AV Jack support disappeared Thorsten Leemhuis
2018-02-26 13:13 ` regression v4.16 on Nokia N900: sound does not work Pavel Machek
2018-02-26 14:02 ` [alsa-devel] " Daniel Baluta
2018-02-26 23:13 ` Pavel Machek
2018-02-26 23:30 ` Pavel Machek
2018-02-27 8:43 ` Linus Walleij
2018-03-02 9:10 ` Pavel Machek
2018-03-02 9:33 ` Linus Walleij
2018-03-02 10:31 ` Pavel Machek
2018-03-02 12:07 ` Linus Walleij
2018-03-02 12:14 ` Pavel Machek
2018-03-02 12:33 ` Linus Walleij
2018-03-02 11:10 ` Pavel Machek
2018-03-02 11:21 ` Pavel Machek
2018-03-02 14:22 ` Andrew F. Davis
2018-03-02 16:53 ` Pavel Machek
2018-03-02 17:08 ` Russell King - ARM Linux
2018-03-02 17:18 ` Andrew F. Davis
2018-02-26 15:43 ` regression v4.16 on Nokia N900:/dev/input/event6 aka AV Jack support disappeared Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224214617.GA22619@amd \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).