From: martin@kaiser.cx (Martin Kaiser)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] ARM: imx: avic: set low-power interrupt mask for imx25
Date: Tue, 27 Feb 2018 22:25:17 +0100 [thread overview]
Message-ID: <20180227212517.GA5227@botnar.kaiser.cx> (raw)
In-Reply-To: <20180224073408.GE3217@dragon>
Hello Shawn and all,
Thus wrote Shawn Guo (shawnguo at kernel.org):
> > +static void __iomem *avic_base, *mx25_ccm_base;
> Keep avic_base line untouched, and add a new one for mx25_ccm_base.
ok
> > static struct irq_domain *domain;
> > #ifdef CONFIG_FIQ
> > @@ -93,6 +97,11 @@ static void avic_irq_suspend(struct irq_data *d)
> > avic_saved_mask_reg[idx] = imx_readl(avic_base + ct->regs.mask);
> > imx_writel(gc->wake_active, avic_base + ct->regs.mask);
> Have a newline here.
ok
> > static void avic_irq_resume(struct irq_data *d)
> > @@ -102,6 +111,11 @@ static void avic_irq_resume(struct irq_data *d)
> > int idx = d->hwirq >> 5;
> > imx_writel(avic_saved_mask_reg[idx], avic_base + ct->regs.mask);
> Ditto
ok
Please note that, as there were no fundamental doubts about my approach,
I submitted a "regular patch" based on this RFC patch a couple of days
later.
I'll update this regular patch and submit a v2.
Best regards,
Martin
prev parent reply other threads:[~2018-02-27 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-09 12:43 [PATCH RFC] ARM: imx: avic: set low-power interrupt mask for imx25 Martin Kaiser
2018-02-09 23:23 ` Fabio Estevam
2018-02-24 7:34 ` Shawn Guo
2018-02-27 21:25 ` Martin Kaiser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227212517.GA5227@botnar.kaiser.cx \
--to=martin@kaiser.cx \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).