From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: mx5: Pass the memory unit-address
Date: Wed, 28 Feb 2018 11:03:29 +0800 [thread overview]
Message-ID: <20180228030328.GC3217@dragon> (raw)
In-Reply-To: <1519784015-16507-1-git-send-email-festevam@gmail.com>
On Tue, Feb 27, 2018 at 11:13:35PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Pass the memory unit-address to fix the following build warnings with W=1:
>
> arch/arm/boot/dts/imx51-zii-rdu1.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
> arch/arm/boot/dts/imx53-tx53-x03x.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
> arch/arm/boot/dts/imx53-tx53-x13x.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>
> In theses cases an empty memory node is passed, which will be filled
> by the bootloader. Passing the memory base address still allows the
> bootloader to fill the memory size.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
One thing I'm unsure is which memory node will be fixed up with correct
memory configuration, considering we will have two memory nodes. One is
the following that defined in imx51.dtsi.
memory { device_type = "memory"; };
And the other is memory at 90000000.
Shawn
> ---
> arch/arm/boot/dts/imx51-zii-rdu1.dts | 4 ++--
> arch/arm/boot/dts/imx53-tx53.dtsi | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index aa36204..14f4d57 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -52,8 +52,8 @@
> };
>
> /* Will be filled by the bootloader */
> - memory {
> - reg = <0 0>;
> + memory at 90000000 {
> + reg = <0x90000000 0>;
> };
>
> aliases {
> diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
> index e77dd0a..69a2af7 100644
> --- a/arch/arm/boot/dts/imx53-tx53.dtsi
> +++ b/arch/arm/boot/dts/imx53-tx53.dtsi
> @@ -50,8 +50,8 @@
> compatible = "karo,tx53", "fsl,imx53";
>
> /* Will be filled by the bootloader */
> - memory {
> - reg = <0 0>;
> + memory at 70000000 {
> + reg = <0x70000000 0>;
> };
>
> aliases {
> --
> 2.7.4
>
next prev parent reply other threads:[~2018-02-28 3:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 2:13 [PATCH] ARM: dts: mx5: Pass the memory unit-address Fabio Estevam
2018-02-28 3:03 ` Shawn Guo [this message]
2018-02-28 12:00 ` Fabio Estevam
2018-03-01 0:41 ` Shawn Guo
2018-03-01 0:43 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228030328.GC3217@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox