From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm_pmu: Use disable_irq_nosync when disabling SPI in CPU teardown hook
Date: Wed, 28 Feb 2018 14:27:29 +0000 [thread overview]
Message-ID: <20180228142729.GA11580@arm.com> (raw)
In-Reply-To: <CAMuHMdWdua0+wsaMnkqRceOO=C5r23F-8jdnkwuR6kLBpUPb2g@mail.gmail.com>
On Wed, Feb 28, 2018 at 03:23:28PM +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 28, 2018 at 2:57 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Mon, Feb 26, 2018 at 04:10:56PM +0000, Will Deacon wrote:
> >> Commit 6de3f79112cc ("arm_pmu: explicitly enable/disable SPIs at hotplug")
> >> moved all of the arm_pmu IRQ enable/disable calls to the CPU hotplug hooks,
> >> regardless of whether they are implemented as PPIs or SPIs. This can
> >> lead to us sleeping from atomic context due to disable_irq blocking:
> >
> >> Acked-by: Acked-by: Mark Rutland <mark.rutland@arm.com>
> >
> > I think something went wrong here when you applied the tag. ;)
>
> In case of respinning:
> Fixes: 6de3f79112cc26bf ("arm_pmu: explicitly enable/disable SPIs at hotplug")
This is already pushed to fixes/core, so I'll leave it up to Catalin whether
he wants to rebase it for that.
Will
prev parent reply other threads:[~2018-02-28 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 16:10 [PATCH] arm_pmu: Use disable_irq_nosync when disabling SPI in CPU teardown hook Will Deacon
2018-02-28 13:57 ` Mark Rutland
2018-02-28 14:23 ` Geert Uytterhoeven
2018-02-28 14:27 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228142729.GA11580@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).