From: andrew.smirnov@gmail.com (Andrey Smirnov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 02/22] nvmem: core: Allow specifying device name verbatim
Date: Wed, 28 Feb 2018 06:40:46 -0800 [thread overview]
Message-ID: <20180228144106.16363-3-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <20180228144106.16363-1-andrew.smirnov@gmail.com>
Add code to allow avoid having nvmem core append a numeric suffix to
the end of the name by passing config->id of -1.
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Carlo Caione <carlo@caione.org>
Cc: Kevin Hilman <khilman@baylibre.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: cphealy at gmail.com
Cc: linux-kernel at vger.kernel.org
Cc: linux-mediatek at lists.infradead.org
Cc: linux-rockchip at lists.infradead.org
Cc: linux-amlogic at lists.infradead.org
Cc: linux-arm-kernel at lists.infradead.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
drivers/nvmem/core.c | 11 ++++++++---
include/linux/nvmem-provider.h | 3 +++
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 35a3dbeea324..99e04cfcc723 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -473,9 +473,14 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
nvmem->reg_read = config->reg_read;
nvmem->reg_write = config->reg_write;
nvmem->dev.of_node = config->dev->of_node;
- dev_set_name(&nvmem->dev, "%s%d",
- config->name ? : "nvmem",
- config->name ? config->id : nvmem->id);
+
+ if (config->id == -1 && config->name) {
+ dev_set_name(&nvmem->dev, "%s", config->name);
+ } else {
+ dev_set_name(&nvmem->dev, "%s%d",
+ config->name ? : "nvmem",
+ config->name ? config->id : nvmem->id);
+ }
nvmem->read_only = device_property_present(config->dev, "read-only") |
config->read_only;
diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
index 27e599222ec1..4889a6c62a81 100644
--- a/include/linux/nvmem-provider.h
+++ b/include/linux/nvmem-provider.h
@@ -43,6 +43,9 @@ typedef int (*nvmem_reg_write_t)(void *priv, unsigned int offset,
* Note: A default "nvmem<id>" name will be assigned to the device if
* no name is specified in its configuration. In such case "<id>" is
* generated with ida_simple_get() and provided id field is ignored.
+ *
+ * Note: Specifying name and setting id to -1 implies a unique device
+ * whose name is provided as-is (kept unaltered).
*/
struct nvmem_config {
struct device *dev;
--
2.14.3
next prev parent reply other threads:[~2018-02-28 14:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 14:40 [PATCH v4 00/22] Verbatim device names and devm_nvmem_(un)register() Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 01/22] nvmem: Document struct nvmem_config Andrey Smirnov
2018-02-28 14:40 ` Andrey Smirnov [this message]
2018-02-28 14:40 ` [PATCH v4 03/22] nvmem: Introduce devm_nvmem_(un)register() Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 04/22] nvmem: vf610-ocotp: Convert to use devm_nvmem_register() Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 05/22] nvmem: imx-ocotp: " Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 06/22] nvmem: uniphier-efuse: " Andrey Smirnov
2018-03-04 0:46 ` kbuild test robot
2018-03-04 0:46 ` [PATCH] nvmem: uniphier-efuse: fix ptr_ret.cocci warnings kbuild test robot
2018-02-28 14:40 ` [PATCH v4 07/22] nvmem: snvs_lgpr: Convert to use devm_nvmem_register() Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 08/22] nvmem: qfprom: " Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 09/22] nvmem: rockchip-efuse: " Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 10/22] nvmem: mtk-efuse: " Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 11/22] nvmem: meson-mx-efuse: " Andrey Smirnov
2018-03-04 11:13 ` [PATCH] nvmem: meson-mx-efuse: fix ptr_ret.cocci warnings kbuild test robot
2018-03-04 11:13 ` [PATCH v4 11/22] nvmem: meson-mx-efuse: Convert to use devm_nvmem_register() kbuild test robot
2018-02-28 14:40 ` [PATCH v4 12/22] nvmem: meson-efuse: " Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 13/22] nvmem: lpc18xx_otp: " Andrey Smirnov
2018-03-04 13:04 ` kbuild test robot
2018-03-04 13:04 ` [PATCH] nvmem: lpc18xx_otp: fix ptr_ret.cocci warnings kbuild test robot
2018-02-28 14:40 ` [PATCH v4 14/22] nvmem: imx-iim: Convert to use devm_nvmem_register() Andrey Smirnov
2018-02-28 14:40 ` [PATCH v4 15/22] nvmem: bcm-ocotp: " Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 16/22] nvmem: meson-efuse: Do no gate COMPILE_TEST with MESON_SM Andrey Smirnov
2018-03-04 3:47 ` kbuild test robot
2018-03-04 17:56 ` kbuild test robot
2018-03-04 17:56 ` [PATCH] nvmem: meson-efuse: fix ptr_ret.cocci warnings kbuild test robot
2018-03-04 18:00 ` [kbuild-all] " Fabio Estevam
2018-02-28 14:41 ` [PATCH v4 17/22] nvmem: snvs_lpgpr: Convert commas to semicolons Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 18/22] nvmem: rockchip-efuse: Make use of of_device_get_match_data() Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 19/22] nvmem: vf610-ocotp: Do not use "&pdev->dev" explicitly Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 20/22] nvmem: rockchip-efuse: " Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 21/22] nvmem: imx-iim: " Andrey Smirnov
2018-02-28 14:41 ` [PATCH v4 22/22] nvmem: bcm-ocotp: " Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228144106.16363-3-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).