* [PATCH] arm: dts: omap3: Add missing #sound-dai-cells
@ 2018-03-01 20:25 Rob Herring
2018-03-01 22:32 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2018-03-01 20:25 UTC (permalink / raw)
To: linux-arm-kernel
dtc now gives the following warnings:
arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
Add the missing #sound-dai-cells property.
Cc: "Beno?t Cousson" <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap at vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
arch/arm/boot/dts/omap3.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
index a005802cd52b..4043ecb38016 100644
--- a/arch/arm/boot/dts/omap3.dtsi
+++ b/arch/arm/boot/dts/omap3.dtsi
@@ -557,6 +557,7 @@
dma-names = "tx", "rx";
clocks = <&mcbsp4_fck>;
clock-names = "fck";
+ #sound-dai-cells = <0>;
status = "disabled";
};
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] arm: dts: omap3: Add missing #sound-dai-cells
2018-03-01 20:25 [PATCH] arm: dts: omap3: Add missing #sound-dai-cells Rob Herring
@ 2018-03-01 22:32 ` Tony Lindgren
2018-03-01 23:28 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2018-03-01 22:32 UTC (permalink / raw)
To: linux-arm-kernel
* Rob Herring <robh@kernel.org> [180301 12:26]:
> dtc now gives the following warnings:
>
> arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
>
> Add the missing #sound-dai-cells property.
Is this needed for the current -rc or is v4.17 OK?
Somehow I'm not seeing these with current -rc or next, is
there some special option (not W=2 :) that you're using?
Regards,
Tony
> Cc: "Beno?t Cousson" <bcousson@baylibre.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: linux-omap at vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/arm/boot/dts/omap3.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index a005802cd52b..4043ecb38016 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -557,6 +557,7 @@
> dma-names = "tx", "rx";
> clocks = <&mcbsp4_fck>;
> clock-names = "fck";
> + #sound-dai-cells = <0>;
> status = "disabled";
> };
>
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm: dts: omap3: Add missing #sound-dai-cells
2018-03-01 22:32 ` Tony Lindgren
@ 2018-03-01 23:28 ` Rob Herring
2018-03-01 23:33 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2018-03-01 23:28 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Mar 1, 2018 at 4:32 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Rob Herring <robh@kernel.org> [180301 12:26]:
>> dtc now gives the following warnings:
>>
>> arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
>> arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
>> arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
>>
>> Add the missing #sound-dai-cells property.
>
> Is this needed for the current -rc or is v4.17 OK?
4.17 is fine.
> Somehow I'm not seeing these with current -rc or next, is
> there some special option (not W=2 :) that you're using?
Upstream dtc which I'm working on syncing to for 4.17.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm: dts: omap3: Add missing #sound-dai-cells
2018-03-01 23:28 ` Rob Herring
@ 2018-03-01 23:33 ` Tony Lindgren
2018-03-05 19:41 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2018-03-01 23:33 UTC (permalink / raw)
To: linux-arm-kernel
* Rob Herring <robh@kernel.org> [180301 23:29]:
> On Thu, Mar 1, 2018 at 4:32 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Rob Herring <robh@kernel.org> [180301 12:26]:
> >> dtc now gives the following warnings:
> >>
> >> arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
> >> arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
> >> arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
> >>
> >> Add the missing #sound-dai-cells property.
> >
> > Is this needed for the current -rc or is v4.17 OK?
>
> 4.17 is fine.
>
> > Somehow I'm not seeing these with current -rc or next, is
> > there some special option (not W=2 :) that you're using?
>
> Upstream dtc which I'm working on syncing to for 4.17.
OK let me know if you want to queue along with your other
changes and I'll ack or else I'll apply it up tomorrow.
Regards,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm: dts: omap3: Add missing #sound-dai-cells
2018-03-01 23:33 ` Tony Lindgren
@ 2018-03-05 19:41 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2018-03-05 19:41 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Mar 1, 2018 at 5:33 PM, Tony Lindgren <tony@atomide.com> wrote:
> * Rob Herring <robh@kernel.org> [180301 23:29]:
>> On Thu, Mar 1, 2018 at 4:32 PM, Tony Lindgren <tony@atomide.com> wrote:
>> > * Rob Herring <robh@kernel.org> [180301 12:26]:
>> >> dtc now gives the following warnings:
>> >>
>> >> arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
>> >> arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
>> >> arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])
>> >>
>> >> Add the missing #sound-dai-cells property.
>> >
>> > Is this needed for the current -rc or is v4.17 OK?
>>
>> 4.17 is fine.
>>
>> > Somehow I'm not seeing these with current -rc or next, is
>> > there some special option (not W=2 :) that you're using?
>>
>> Upstream dtc which I'm working on syncing to for 4.17.
>
> OK let me know if you want to queue along with your other
> changes and I'll ack or else I'll apply it up tomorrow.
Please apply it.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-05 19:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-01 20:25 [PATCH] arm: dts: omap3: Add missing #sound-dai-cells Rob Herring
2018-03-01 22:32 ` Tony Lindgren
2018-03-01 23:28 ` Rob Herring
2018-03-01 23:33 ` Tony Lindgren
2018-03-05 19:41 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).