From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Fri, 2 Mar 2018 13:14:42 +0100 Subject: [alsa-devel] regression v4.16 on Nokia N900: sound does not work In-Reply-To: References: <20180224214617.GA22619@amd> <71aa88ec-d4df-b49c-7d73-27197f468491@leemhuis.info> <20180226131318.GA14045@amd> <20180226231336.GA18565@amd> <20180302091025.GC30267@amd> <20180302103127.GA2081@amd> Message-ID: <20180302121442.GB28931@amd> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi! > >> Ok, so this code looks pretty crazy to me: I tried removing the > >> "of_find_spi_gpio" part, and audio started working. > > > > Hmm. Looks like audio is working w/o any changes, too. Not sure why > > festival hung on me before. > > Does it mean that mainline is working find for you or > do we need to look deeper into the problem in the OF > lookup? It now works for me. (But take a look at the patch I sent -- I believe you are still overwriting return values in a bad way, and code is quite confusing). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: