public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0
Date: Fri, 2 Mar 2018 15:26:56 +0300	[thread overview]
Message-ID: <20180302122655.uckejonjyzt4vjd3@mwanda> (raw)
In-Reply-To: <20180302121929.GY9418@n2100.armlinux.org.uk>

Ok, but in that case the original code is still wrong because it returns
early with success.  I guess it could be changed to:

	if (irq <= 0)
		return -ENXIO;

regards,
dan carpenter

  reply	other threads:[~2018-03-02 12:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 20:34 [PATCH] i2c: s3c2410: Properly handle interrupts of number 0 Krzysztof Kozlowski
2018-03-02 10:29 ` Wolfram Sang
2018-03-02 11:00   ` Dan Carpenter
2018-03-02 11:02     ` Dan Carpenter
2018-03-02 11:08     ` Wolfram Sang
2018-03-02 11:19 ` Russell King - ARM Linux
2018-03-02 11:49   ` Dan Carpenter
2018-03-02 12:19     ` Russell King - ARM Linux
2018-03-02 12:26       ` Dan Carpenter [this message]
2018-03-02 12:34         ` Russell King - ARM Linux
2018-03-02 12:46   ` Wolfram Sang
2018-03-02 12:59     ` Russell King - ARM Linux
2018-03-02 13:58       ` Wolfram Sang
2018-03-02 14:09         ` Dan Carpenter
2018-03-02 15:32           ` Russell King - ARM Linux
2018-03-02 16:28             ` Mark Rutland
2018-03-03 16:25               ` Andy Shevchenko
2018-03-03 18:36                 ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180302122655.uckejonjyzt4vjd3@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox