From mboxrd@z Thu Jan 1 00:00:00 1970 From: lkp@intel.com (kbuild test robot) Date: Sun, 4 Mar 2018 21:04:28 +0800 Subject: [PATCH] nvmem: lpc18xx_otp: fix ptr_ret.cocci warnings In-Reply-To: <20180228144106.16363-14-andrew.smirnov@gmail.com> References: <20180228144106.16363-14-andrew.smirnov@gmail.com> Message-ID: <20180304130428.GA11571@lkp-hsx02> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org From: Fengguang Wu drivers/nvmem/lpc18xx_otp.c:90:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: e738282235ec ("nvmem: lpc18xx_otp: Convert to use devm_nvmem_register()") CC: Andrey Smirnov Signed-off-by: Fengguang Wu --- lpc18xx_otp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/nvmem/lpc18xx_otp.c +++ b/drivers/nvmem/lpc18xx_otp.c @@ -87,10 +87,7 @@ static int lpc18xx_otp_probe(struct plat lpc18xx_otp_nvmem_config.priv = otp; nvmem = devm_nvmem_register(&pdev->dev, &lpc18xx_otp_nvmem_config); - if (IS_ERR(nvmem)) - return PTR_ERR(nvmem); - - return 0; + return PTR_ERR_OR_ZERO(nvmem); } static const struct of_device_id lpc18xx_otp_dt_ids[] = {