* [PATCH 1/3] apalis_t30/tk1, colibri_t20/t30: fix i2c bus frequencies
2018-02-10 1:36 [PATCH 0/3] ARM: dts: tegra: apalis/colibri updates Marcel Ziswiler
@ 2018-02-10 1:36 ` Marcel Ziswiler
2018-02-10 1:36 ` [PATCH 2/3] ARM: dts: tegra: apalis/colibri: use correct compatible for rtc Marcel Ziswiler
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Marcel Ziswiler @ 2018-02-10 1:36 UTC (permalink / raw)
To: linux-arm-kernel
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Use a faster speed of 400 kbit/s for regular I2C busses.
Use a slower speed of 10 kbit/s for DDC/EDID to improve reliability.
Use a slower speed of 100 kbit/s for power I2C to be within specs of
the LM95245 temperature sensor.
While at it further annotate I2C pin usage.
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
arch/arm/boot/dts/tegra124-apalis-eval.dts | 5 ++---
arch/arm/boot/dts/tegra124-apalis.dtsi | 2 +-
arch/arm/boot/dts/tegra20-colibri-512.dtsi | 16 +++++++++++-----
arch/arm/boot/dts/tegra30-apalis-eval.dts | 2 +-
arch/arm/boot/dts/tegra30-apalis.dtsi | 2 +-
arch/arm/boot/dts/tegra30-colibri-eval-v3.dts | 2 +-
arch/arm/boot/dts/tegra30-colibri.dtsi | 2 +-
7 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/arch/arm/boot/dts/tegra124-apalis-eval.dts b/arch/arm/boot/dts/tegra124-apalis-eval.dts
index ecffcd115fa7..66b6c45ee865 100644
--- a/arch/arm/boot/dts/tegra124-apalis-eval.dts
+++ b/arch/arm/boot/dts/tegra124-apalis-eval.dts
@@ -105,7 +105,7 @@
*/
i2c at 7000c000 {
status = "okay";
- clock-frequency = <100000>;
+ clock-frequency = <400000>;
pcie-switch at 58 {
compatible = "plx,pex8605";
@@ -124,7 +124,6 @@
*/
hdmi_ddc: i2c at 7000c400 {
status = "okay";
- clock-frequency = <100000>;
};
/*
@@ -133,7 +132,7 @@
*/
i2c at 7000c500 {
status = "okay";
- clock-frequency = <100000>;
+ clock-frequency = <400000>;
};
/* I2C4 (DDC): unused */
diff --git a/arch/arm/boot/dts/tegra124-apalis.dtsi b/arch/arm/boot/dts/tegra124-apalis.dtsi
index 5d9b18ef5af6..7aef8928e115 100644
--- a/arch/arm/boot/dts/tegra124-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra124-apalis.dtsi
@@ -1579,7 +1579,7 @@
};
hdmi_ddc: i2c at 7000c400 {
- clock-frequency = <100000>;
+ clock-frequency = <10000>;
};
/* PWR_I2C: power I2C to audio codec, PMIC and temperature sensor */
diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
index 813ae34edd6a..5c202b3e3bb1 100644
--- a/arch/arm/boot/dts/tegra20-colibri-512.dtsi
+++ b/arch/arm/boot/dts/tegra20-colibri-512.dtsi
@@ -213,21 +213,27 @@
GPIO_ACTIVE_HIGH>;
};
+ /*
+ * GEN1_I2C: I2C_SDA/SCL on SODIMM pin 194/196 (e.g. RTC on carrier
+ * board)
+ */
i2c at 7000c000 {
clock-frequency = <400000>;
};
+ /* DDC_SCL/SDA on X3 pin 15/16 (e.g. display EDID) */
i2c_ddc: i2c at 7000c400 {
- clock-frequency = <100000>;
+ clock-frequency = <10000>;
};
- i2c at 7000c500 {
- clock-frequency = <400000>;
- };
+ /* GEN2_I2C: unused */
+ /* CAM/GEN3_I2C: used as EXT_IO1/2 GPIOs on SODIMM pin 133/127 */
+
+ /* PWR_I2C: power I2C to PMIC and temperature sensor (On-module) */
i2c at 7000d000 {
status = "okay";
- clock-frequency = <400000>;
+ clock-frequency = <100000>;
pmic: tps6586x at 34 {
compatible = "ti,tps6586x";
diff --git a/arch/arm/boot/dts/tegra30-apalis-eval.dts b/arch/arm/boot/dts/tegra30-apalis-eval.dts
index 07b945b0391a..fdca527a2248 100644
--- a/arch/arm/boot/dts/tegra30-apalis-eval.dts
+++ b/arch/arm/boot/dts/tegra30-apalis-eval.dts
@@ -79,7 +79,7 @@
*/
i2c at 7000c000 {
status = "okay";
- clock-frequency = <100000>;
+ clock-frequency = <400000>;
pcie-switch at 58 {
compatible = "plx,pex8605";
diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
index bfb7913c0657..676a4c4b1512 100644
--- a/arch/arm/boot/dts/tegra30-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
@@ -437,7 +437,7 @@
};
hdmiddc: i2c at 7000c700 {
- clock-frequency = <100000>;
+ clock-frequency = <10000>;
};
/*
diff --git a/arch/arm/boot/dts/tegra30-colibri-eval-v3.dts b/arch/arm/boot/dts/tegra30-colibri-eval-v3.dts
index b307feb7c330..8c62833197e5 100644
--- a/arch/arm/boot/dts/tegra30-colibri-eval-v3.dts
+++ b/arch/arm/boot/dts/tegra30-colibri-eval-v3.dts
@@ -56,7 +56,7 @@
*/
i2c at 7000c000 {
status = "okay";
- clock-frequency = <100000>;
+ clock-frequency = <400000>;
/* M41T0M6 real time clock on carrier board */
rtc at 68 {
diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
index 139bfa028b04..1f77273521bf 100644
--- a/arch/arm/boot/dts/tegra30-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
@@ -215,7 +215,7 @@
};
hdmiddc: i2c at 7000c700 {
- clock-frequency = <100000>;
+ clock-frequency = <10000>;
};
/*
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 2/3] ARM: dts: tegra: apalis/colibri: use correct compatible for rtc
2018-02-10 1:36 [PATCH 0/3] ARM: dts: tegra: apalis/colibri updates Marcel Ziswiler
2018-02-10 1:36 ` [PATCH 1/3] apalis_t30/tk1, colibri_t20/t30: fix i2c bus frequencies Marcel Ziswiler
@ 2018-02-10 1:36 ` Marcel Ziswiler
2018-02-10 1:36 ` [PATCH 3/3] ARM: dts: tegra: apalis/colibri: remove unneeded reg property Marcel Ziswiler
2018-03-08 15:11 ` [PATCH 0/3] ARM: dts: tegra: apalis/colibri updates Thierry Reding
3 siblings, 0 replies; 5+ messages in thread
From: Marcel Ziswiler @ 2018-02-10 1:36 UTC (permalink / raw)
To: linux-arm-kernel
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
All Toradex Carrier Boards use a st,m41t0 compatible RTC. Compared to a
st,m41t00 this RTC has also an oscillator fail bit which allows to
detect when the RTC lost track of time.
Similar to commit c53bec16b150 ("ARM: dts: colibri/apalis: use correct
compatible for RTC") covering our NXP i.MX and Vybrid based modules.
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
arch/arm/boot/dts/tegra124-apalis-eval.dts | 2 +-
arch/arm/boot/dts/tegra30-apalis-eval.dts | 2 +-
arch/arm/boot/dts/tegra30-colibri-eval-v3.dts | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/tegra124-apalis-eval.dts b/arch/arm/boot/dts/tegra124-apalis-eval.dts
index 66b6c45ee865..af6c566e8ac4 100644
--- a/arch/arm/boot/dts/tegra124-apalis-eval.dts
+++ b/arch/arm/boot/dts/tegra124-apalis-eval.dts
@@ -114,7 +114,7 @@
/* M41T0M6 real time clock on carrier board */
rtc at 68 {
- compatible = "st,m41t00";
+ compatible = "st,m41t0";
reg = <0x68>;
};
};
diff --git a/arch/arm/boot/dts/tegra30-apalis-eval.dts b/arch/arm/boot/dts/tegra30-apalis-eval.dts
index fdca527a2248..0dc85a20bd45 100644
--- a/arch/arm/boot/dts/tegra30-apalis-eval.dts
+++ b/arch/arm/boot/dts/tegra30-apalis-eval.dts
@@ -88,7 +88,7 @@
/* M41T0M6 real time clock on carrier board */
rtc at 68 {
- compatible = "st,m41t00";
+ compatible = "st,m41t0";
reg = <0x68>;
};
};
diff --git a/arch/arm/boot/dts/tegra30-colibri-eval-v3.dts b/arch/arm/boot/dts/tegra30-colibri-eval-v3.dts
index 8c62833197e5..16e1f387aa6d 100644
--- a/arch/arm/boot/dts/tegra30-colibri-eval-v3.dts
+++ b/arch/arm/boot/dts/tegra30-colibri-eval-v3.dts
@@ -60,7 +60,7 @@
/* M41T0M6 real time clock on carrier board */
rtc at 68 {
- compatible = "st,m41t00";
+ compatible = "st,m41t0";
reg = <0x68>;
};
};
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 3/3] ARM: dts: tegra: apalis/colibri: remove unneeded reg property
2018-02-10 1:36 [PATCH 0/3] ARM: dts: tegra: apalis/colibri updates Marcel Ziswiler
2018-02-10 1:36 ` [PATCH 1/3] apalis_t30/tk1, colibri_t20/t30: fix i2c bus frequencies Marcel Ziswiler
2018-02-10 1:36 ` [PATCH 2/3] ARM: dts: tegra: apalis/colibri: use correct compatible for rtc Marcel Ziswiler
@ 2018-02-10 1:36 ` Marcel Ziswiler
2018-03-08 15:11 ` [PATCH 0/3] ARM: dts: tegra: apalis/colibri updates Thierry Reding
3 siblings, 0 replies; 5+ messages in thread
From: Marcel Ziswiler @ 2018-02-10 1:36 UTC (permalink / raw)
To: linux-arm-kernel
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
As described in
Documentation/devicetree/bindings/input/touchscreen/stmpe.txt there is
no 'reg' property under stmpe_touchscreen, so remove it to fix the
following build warning with W=1:
arch/arm/boot/dts/tegra30-apalis-eval.dtb:
Warning (unit_address_vs_reg): Node
/i2c at 7000d000/stmpe811 at 41/stmpe_touchscreen has a reg or ranges
property, but no unit name
Similar to commit 89277e8e2679 ("ARM: dts: imx6qdl-apalis: Remove
unneeded reg property").
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
arch/arm/boot/dts/tegra30-apalis.dtsi | 1 -
arch/arm/boot/dts/tegra30-colibri.dtsi | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/tegra30-apalis.dtsi b/arch/arm/boot/dts/tegra30-apalis.dtsi
index 676a4c4b1512..d1d21ec2a844 100644
--- a/arch/arm/boot/dts/tegra30-apalis.dtsi
+++ b/arch/arm/boot/dts/tegra30-apalis.dtsi
@@ -597,7 +597,6 @@
stmpe_touchscreen at 0 {
compatible = "st,stmpe-ts";
- reg = <0>;
/* 3.25 MHz ADC clock speed */
st,adc-freq = <1>;
/* 8 sample average control */
diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
index 1f77273521bf..c44d8c40c410 100644
--- a/arch/arm/boot/dts/tegra30-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
@@ -363,7 +363,6 @@
stmpe_touchscreen {
compatible = "st,stmpe-ts";
- reg = <0>;
/* 3.25 MHz ADC clock speed */
st,adc-freq = <1>;
/* 8 sample average control */
--
2.14.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH 0/3] ARM: dts: tegra: apalis/colibri updates
2018-02-10 1:36 [PATCH 0/3] ARM: dts: tegra: apalis/colibri updates Marcel Ziswiler
` (2 preceding siblings ...)
2018-02-10 1:36 ` [PATCH 3/3] ARM: dts: tegra: apalis/colibri: remove unneeded reg property Marcel Ziswiler
@ 2018-03-08 15:11 ` Thierry Reding
3 siblings, 0 replies; 5+ messages in thread
From: Thierry Reding @ 2018-03-08 15:11 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Feb 10, 2018 at 02:36:35AM +0100, Marcel Ziswiler wrote:
>
> This series fixes the I2C bus frequencies, uses the correct compatible
> for the RTC and removes an unneeded reg property for Tegra based
> Toradex Apalis and Colibri modules.
>
>
> Marcel Ziswiler (3):
> apalis_t30/tk1, colibri_t20/t30: fix i2c bus frequencies
> ARM: dts: tegra: apalis/colibri: use correct compatible for rtc
> ARM: dts: tegra: apalis/colibri: remove unneeded reg property
>
> arch/arm/boot/dts/tegra124-apalis-eval.dts | 7 +++----
> arch/arm/boot/dts/tegra124-apalis.dtsi | 2 +-
> arch/arm/boot/dts/tegra20-colibri-512.dtsi | 16 +++++++++++-----
> arch/arm/boot/dts/tegra30-apalis-eval.dts | 4 ++--
> arch/arm/boot/dts/tegra30-apalis.dtsi | 3 +--
> arch/arm/boot/dts/tegra30-colibri-eval-v3.dts | 4 ++--
> arch/arm/boot/dts/tegra30-colibri.dtsi | 3 +--
> 7 files changed, 21 insertions(+), 18 deletions(-)
Applied, thanks.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180308/2c7bd8da/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread