From mboxrd@z Thu Jan  1 00:00:00 1970
From: shawnguo@kernel.org (Shawn Guo)
Date: Thu, 15 Mar 2018 11:13:18 +0800
Subject: [PATCH] soc: imx: gpc: Use kemdup() function
In-Reply-To: <1520810382-13341-1-git-send-email-festevam@gmail.com>
References: <1520810382-13341-1-git-send-email-festevam@gmail.com>
Message-ID: <20180315031317.GJ26859@dragon>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Fabio,

On Sun, Mar 11, 2018 at 08:19:42PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Use kmemdup() rather than duplicating its implementation.
> 
> Detected with Coccinelle script.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

I copied you on my reply to Andrey Smirnov, in which I requested to
use platform_device_add_data() for his patches.  That said, your patches
will be dropped as well.

Shawn

> ---
>  drivers/soc/imx/gpc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index 196f17b..cc3bad8 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -444,12 +444,12 @@ static int imx_gpc_probe(struct platform_device *pdev)
>  			if (domain_index >= of_id_data->num_domains)
>  				continue;
>  
> -			domain = kmalloc(sizeof(*domain), GFP_KERNEL);
> +			domain = kmemdup(&imx_gpc_domains[domain_index],
> +					 sizeof(*domain), GFP_KERNEL);
>  			if (!domain) {
>  				of_node_put(np);
>  				return -ENOMEM;
>  			}
> -			memcpy(domain, &imx_gpc_domains[domain_index], sizeof(*domain));
>  			domain->regmap = regmap;
>  			domain->ipg_rate_mhz = ipg_rate_mhz;
>  
> -- 
> 2.7.4
>