From: gregkh@linuxfoundation.org (gregkh at linuxfoundation.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: mvebu-uart: fix tx lost characters
Date: Thu, 15 Mar 2018 17:55:16 +0100 [thread overview]
Message-ID: <20180315165516.GA9519@kroah.com> (raw)
In-Reply-To: <3B588D51285A4A4D8D39C94212E078262748ED@SPQCMBX02.exfo.com>
On Tue, Mar 06, 2018 at 03:47:03PM +0000, Gabriel Matni wrote:
> From: Gabriel Matni <gabriel.matni@exfo.com>
>
> Fixes missing characters on kernel console at low baud rates (i.e.9600).
> The driver should poll TX_RDY or TX_FIFO_EMP instead of TX_EMP to ensure
> that the transmitter holding register (THR) is ready to receive a new byte.
>
> TX_EMP tells us when it is possible to send a break sequence via
> SND_BRK_SEQ. While this also indicates that both the THR and the TSR are
> empty, it does not guarantee that a new byte can be written just yet.
>
> Fixes: 30530791a7a0 ("serial: mvebu-uart: initial support for Armada-3700 serial port")
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
> Signed-off-by: Gabriel Matni <gabriel.matni@exfo.com>
> ---
> drivers/tty/serial/mvebu-uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c
> index a100e98259d7..f0df0640208e 100644
> --- a/drivers/tty/serial/mvebu-uart.c
> +++ b/drivers/tty/serial/mvebu-uart.c
> @@ -618,7 +618,7 @@ static void wait_for_xmitr(struct uart_port *port)
> u32 val;
>
> readl_poll_timeout_atomic(port->membase + UART_STAT, val,
> - (val & STAT_TX_EMP), 1, 10000);
> + (val & STAT_TX_RDY(port)), 1, 10000);
> }
>
> static void mvebu_uart_console_putchar(struct uart_port *port, int ch)
> --
> 2.7.4
Patch is corrupted and can not be applied :(
Please fix up and resend.
Also be sure to cc: the linux-serial mailing list,
scripts/get_maintainer.pl is your friend...
thanks,
greg k-h
next prev parent reply other threads:[~2018-03-15 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 15:47 [PATCH] serial: mvebu-uart: fix tx lost characters Gabriel Matni
2018-03-15 16:55 ` gregkh at linuxfoundation.org [this message]
2018-03-15 18:55 ` Gabriel Matni
2018-03-15 20:21 ` Miquel Raynal
2018-03-16 13:45 ` Gabriel Matni
2018-03-20 9:32 ` gregkh at linuxfoundation.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315165516.GA9519@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).