From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: hummingboard2: convert onboard audio to simple-audio-card
Date: Mon, 19 Mar 2018 14:23:50 +0000 [thread overview]
Message-ID: <20180319142350.GE2743@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20180319135326.24357-1-mporter@konsulko.com>
On Mon, Mar 19, 2018 at 09:53:26AM -0400, Matt Porter wrote:
> The HB2 onboard audio currently makes use of the imx-audio-sgtl5000
> binding. This binding does not support auxiliary audio devices such
> as external amplifiers. The simple-audio-card binding does support
> this property which allows systems incorporating the HB2 to easily
> add an auxiliary device that's attached to the HB2 audio jack with
> an overlay. Convert HB2 to use simple-audio-card for the onboard
> audio to allow for this additional flexibility.
What is driving this change? Why only make this change for HB2 and
not HB?
>
> Signed-off-by: Matt Porter <mporter@konsulko.com>
> ---
> arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 48 +++++++++++++++++++++++-----
> 1 file changed, 40 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
> index dffbc92e0023..587251ab76ec 100644
> --- a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
> @@ -38,6 +38,7 @@
> * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> * OTHER DEALINGS IN THE SOFTWARE.
> */
> +#include <dt-bindings/sound/fsl-imx-audmux.h>
>
> / {
> chosen {
> @@ -145,22 +146,52 @@
> vin-supply = <&v_5v0>;
> };
>
> - sound-sgtl5000 {
> - audio-codec = <&sgtl5000>;
> - audio-routing =
> + audio: sound-sgtl5000 {
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "On-Board Codec";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,bitclock-master = <&sound_codec>;
> + simple-audio-card,frame-master = <&sound_codec>;
> + simple-audio-card,widgets =
> + "Microphone", "Mic Jack",
> + "Headphone", "Headphone Jack";
> + simple-audio-card,routing =
> "MIC_IN", "Mic Jack",
> "Mic Jack", "Mic Bias",
> "Headphone Jack", "HP_OUT";
> - compatible = "fsl,imx-audio-sgtl5000";
> - model = "On-board Codec";
> - mux-ext-port = <5>;
> - mux-int-port = <1>;
> - ssi-controller = <&ssi1>;
> +
> + sound_cpu: simple-audio-card,cpu {
> + sound-dai = <&ssi1>;
> + };
> +
> + sound_codec: simple-audio-card,codec {
> + sound-dai = <&sgtl5000>;
> + };
> };
> };
>
> &audmux {
> status = "okay";
> +
> + ssi1 {
> + fsl,audmux-port = <0>;
> + fsl,port-config = <
> + (IMX_AUDMUX_V2_PTCR_SYN |
> + IMX_AUDMUX_V2_PTCR_TFSEL(4) |
> + IMX_AUDMUX_V2_PTCR_TCSEL(4) |
> + IMX_AUDMUX_V2_PTCR_TFSDIR |
> + IMX_AUDMUX_V2_PTCR_TCLKDIR)
> + IMX_AUDMUX_V2_PDCR_RXDSEL(4)
> + >;
> + };
> +
> + pins5 {
> + fsl,audmux-port = <4>;
> + fsl,port-config = <
> + IMX_AUDMUX_V2_PTCR_SYN
> + IMX_AUDMUX_V2_PDCR_RXDSEL(0)
> + >;
> + };
> };
>
> &ecspi2 {
> @@ -193,6 +224,7 @@
> compatible = "fsl,sgtl5000";
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_hummingboard2_sgtl5000>;
> + #sound-dai-cells = <0>;
> reg = <0x0a>;
> VDDA-supply = <&v_3v2>;
> VDDD-supply = <&vcc_1p8>;
> --
> 2.11.0
>
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2018-03-19 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 13:53 [PATCH] arm: dts: hummingboard2: convert onboard audio to simple-audio-card Matt Porter
2018-03-19 14:13 ` Fabio Estevam
2018-03-19 14:23 ` Russell King - ARM Linux [this message]
2018-03-19 15:02 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319142350.GE2743@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox