Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: ezequiel@vanguardiasur.com.ar (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] Fix audio regression on rk3288
Date: Tue, 20 Mar 2018 13:03:29 -0300	[thread overview]
Message-ID: <20180320160332.13212-1-ezequiel@vanguardiasur.com.ar> (raw)

From: Ezequiel Garcia <ezequiel@collabora.co.uk>

Currently on rk3288 boards the ASoC machine driver fails to load,
breaking audio support.

Apparently, the regression was introduced by commit 24069b589b02
("ASoC: hdmi-codec: remove multi detection support") which changed
the codec name.

If there is a lesson here, it would be about binding drivers using
strings and how fragile this is. Or maybe it's about regression
testing. Or maybe there isn't a lesson.

Anyway, the first patch fixes the regression; the second patch
makes the machine driver selects all the codecs it; finally
the third patch is just a binding documentation fix.

Tested on a Radxa Rock2 Square board.

Ezequiel Garcia (3):
  ASoC: rockchip: Fix dai_name for HDMI codec
  ASoC: rockchip: rk3288-hdmi-analog: Select needed codecs
  dt-bindings: sound: rockchip Fix compatible string in example

 .../devicetree/bindings/sound/rockchip,rk3288-hdmi-analog.txt          | 2 +-
 sound/soc/rockchip/Kconfig                                             | 3 +++
 sound/soc/rockchip/rk3288_hdmi_analog.c                                | 2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)

-- 
2.16.2

             reply	other threads:[~2018-03-20 16:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 16:03 Ezequiel Garcia [this message]
2018-03-20 16:03 ` [PATCH 1/3] ASoC: rockchip: Fix dai_name for HDMI codec Ezequiel Garcia
2018-03-21  1:57   ` Applied "ASoC: rockchip: Fix dai_name for HDMI codec" to the asoc tree Mark Brown
2018-03-20 16:03 ` [PATCH 2/3] ASoC: rockchip: rk3288-hdmi-analog: Select needed codecs Ezequiel Garcia
2018-03-21  1:57   ` Applied "ASoC: rockchip: rk3288-hdmi-analog: Select needed codecs" to the asoc tree Mark Brown
2018-03-20 16:03 ` [PATCH 3/3] dt-bindings: sound: rockchip Fix compatible string in example Ezequiel Garcia
2018-03-21  1:52   ` Mark Brown
2018-03-21  1:57   ` Applied "ASoC: rockchip: Fix compatible string in example" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180320160332.13212-1-ezequiel@vanguardiasur.com.ar \
    --to=ezequiel@vanguardiasur.com.ar \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox