From: brgl@bgdev.pl (Bartosz Golaszewski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] remoteproc: da8xx: use the reset framework
Date: Wed, 21 Mar 2018 13:08:06 +0100 [thread overview]
Message-ID: <20180321120807.18032-8-brgl@bgdev.pl> (raw)
In-Reply-To: <20180321120807.18032-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Switch to using the reset framework instead of handcoded reset routines
we used so far.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/remoteproc/da8xx_remoteproc.c | 30 +++++++++++++++++++++++++-----
1 file changed, 25 insertions(+), 5 deletions(-)
diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
index 83f2d66ad3a9..fc29b78d0f77 100644
--- a/drivers/remoteproc/da8xx_remoteproc.c
+++ b/drivers/remoteproc/da8xx_remoteproc.c
@@ -10,6 +10,7 @@
#include <linux/bitops.h>
#include <linux/clk.h>
+#include <linux/reset.h>
#include <linux/err.h>
#include <linux/interrupt.h>
#include <linux/io.h>
@@ -20,8 +21,6 @@
#include <linux/platform_device.h>
#include <linux/remoteproc.h>
-#include <mach/clock.h> /* for davinci_clk_reset_assert/deassert() */
-
#include "remoteproc_internal.h"
static char *da8xx_fw_name;
@@ -72,6 +71,7 @@ struct da8xx_rproc {
struct da8xx_rproc_mem *mem;
int num_mems;
struct clk *dsp_clk;
+ struct reset_control *dsp_reset;
void (*ack_fxn)(struct irq_data *data);
struct irq_data *irq_data;
void __iomem *chipsig;
@@ -138,6 +138,7 @@ static int da8xx_rproc_start(struct rproc *rproc)
struct device *dev = rproc->dev.parent;
struct da8xx_rproc *drproc = (struct da8xx_rproc *)rproc->priv;
struct clk *dsp_clk = drproc->dsp_clk;
+ struct reset_control *dsp_reset = drproc->dsp_reset;
int rv;
/* hw requires the start (boot) address be on 1KB boundary */
@@ -155,7 +156,11 @@ static int da8xx_rproc_start(struct rproc *rproc)
return rv;
}
- davinci_clk_reset_deassert(dsp_clk);
+ rv = reset_control_deassert(dsp_reset);
+ if (rv) {
+ dev_err(dev, "reset_control_deassert() failed: %d\n", rv);
+ return rv;
+ }
return 0;
}
@@ -163,8 +168,15 @@ static int da8xx_rproc_start(struct rproc *rproc)
static int da8xx_rproc_stop(struct rproc *rproc)
{
struct da8xx_rproc *drproc = rproc->priv;
+ int rv;
+
+ rv = reset_control_assert(drproc->dsp_reset);
+ if (rv) {
+ dev_err(rproc->dev.parent,
+ "reset_control_assert() failed: %d\n", rv);
+ return rv;
+ }
- davinci_clk_reset_assert(drproc->dsp_clk);
clk_disable_unprepare(drproc->dsp_clk);
return 0;
@@ -232,6 +244,7 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
struct resource *bootreg_res;
struct resource *chipsig_res;
struct clk *dsp_clk;
+ struct reset_control *dsp_reset;
void __iomem *chipsig;
void __iomem *bootreg;
int irq;
@@ -268,6 +281,13 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
return PTR_ERR(dsp_clk);
}
+ dsp_reset = devm_reset_control_get_exclusive(dev, NULL);
+ if (IS_ERR(dsp_reset)) {
+ dev_err(dev, "unable to get reset control: %ld\n",
+ PTR_ERR(dsp_reset));
+ return PTR_ERR(dsp_reset);
+ }
+
if (dev->of_node) {
ret = of_reserved_mem_device_init(dev);
if (ret) {
@@ -309,7 +329,7 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
* *not* in reset, but da8xx_rproc_start() needs the DSP to be
* held in reset at the time it is called.
*/
- ret = davinci_clk_reset_assert(drproc->dsp_clk);
+ ret = reset_control_assert(dsp_reset);
if (ret)
goto free_rproc;
--
2.16.1
next prev parent reply other threads:[~2018-03-21 12:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 12:07 [PATCH 0/8] ARM: davinci: complete the conversion to using the reset framework Bartosz Golaszewski
2018-03-21 12:08 ` [PATCH 1/8] reset: modify the way reset lookup works for board files Bartosz Golaszewski
2018-03-21 12:08 ` [PATCH 2/8] ARM: davinci: dts: make psc0 a reset provider Bartosz Golaszewski
2018-03-21 12:08 ` [PATCH 3/8] ARM: davinci: dts: add a reset control to the dsp node Bartosz Golaszewski
2018-03-21 14:04 ` Bartosz Golaszewski
2018-03-21 16:07 ` David Lechner
2018-03-21 12:08 ` [PATCH 4/8] clk: davinci: add a reset lookup table for psc0 Bartosz Golaszewski
2018-03-21 16:01 ` David Lechner
2018-03-21 16:08 ` Bartosz Golaszewski
2018-03-21 16:17 ` David Lechner
2018-03-23 9:07 ` Bartosz Golaszewski
2018-03-21 12:08 ` [PATCH 5/8] remoteproc: da8xx: add the missing checke for clk_enable() Bartosz Golaszewski
2018-03-21 16:21 ` David Lechner
2018-03-21 12:08 ` [PATCH 6/8] remoteproc: da8xx: prepare and unprepare the clock where needed Bartosz Golaszewski
2018-03-21 12:08 ` Bartosz Golaszewski [this message]
2018-03-21 12:08 ` [PATCH 8/8] clk: davinci: kill davinci_clk_reset_assert/deassert() Bartosz Golaszewski
2018-03-21 16:23 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321120807.18032-8-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).