linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [net-next PATCH v2 08/10] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes
Date: Tue, 27 Mar 2018 19:35:09 +0200	[thread overview]
Message-ID: <20180327173509.GQ5862@lunn.ch> (raw)
In-Reply-To: <1522168309-12338-9-git-send-email-m-karicheri2@ti.com>

> +	} else if (slave->link_interface == RGMII_LINK_MAC_PHY) {
> +		has_phy = true;
> +		phy_mode = of_get_phy_mode(slave->node);
> +		/* if phy-mode is not present, default to
> +		 * PHY_INTERFACE_MODE_RGMII
> +		 */
> +		if (phy_mode < 0)
> +			phy_mode = PHY_INTERFACE_MODE_RGMII;

Can only do RGMII? Maybe add a call here to
phy_interface_mode_is_rgmii() and return -EINVAL if DT contains
something which is not RGMII?

	  Andrew

  reply	other threads:[~2018-03-27 17:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27 16:31 [net-next PATCH v2 00/10] Add support for netcp driver on K2G SoC Murali Karicheri
2018-03-27 16:31 ` [net-next PATCH v2 01/10] soc: ti: K2G: enhancement to support QMSS in NSS Murali Karicheri
2018-03-28 19:01   ` [net-next, v2, " Grygorii Strashko
2018-03-29 14:50     ` Murali Karicheri
2018-03-29 14:59     ` Murali Karicheri
2018-03-27 16:31 ` [net-next PATCH v2 02/10] soc: ti: K2G: provide APIs to support driver probe deferral Murali Karicheri
2018-03-27 16:31 ` [net-next PATCH v2 03/10] net: netcp: ethss: make call to gbe_sgmii_config() conditional Murali Karicheri
2018-03-27 17:13   ` Andrew Lunn
2018-03-27 19:20     ` Murali Karicheri
2018-03-27 17:18   ` Andrew Lunn
2018-03-27 19:39     ` Murali Karicheri
2018-03-29 16:27     ` Murali Karicheri
2018-03-27 16:31 ` [net-next PATCH v2 04/10] net: netcp: ethss: add support for handling sgmii link interface Murali Karicheri
2018-03-27 16:31 ` [net-next PATCH v2 05/10] net: netcp: ethss: use rgmii link status for 2u cpsw hardware Murali Karicheri
2018-03-27 17:29   ` Andrew Lunn
2018-03-27 21:07     ` Murali Karicheri
2018-03-29 16:35     ` Murali Karicheri
2018-03-27 16:31 ` [net-next PATCH v2 06/10] net: netcp: ethss: map vlan priorities to zero flow Murali Karicheri
2018-03-27 16:31 ` [net-next PATCH v2 07/10] net: netcp: ethss: re-use stats handling code for 2u hardware Murali Karicheri
2018-03-27 16:31 ` [net-next PATCH v2 08/10] net: netcp: ethss: use of_get_phy_mode() to support different RGMII modes Murali Karicheri
2018-03-27 17:35   ` Andrew Lunn [this message]
2018-03-29 20:03     ` Murali Karicheri
2018-03-27 16:31 ` [net-next PATCH v2 09/10] Revert "net: netcp: remove dead code from the driver" Murali Karicheri
2018-03-27 16:31 ` [net-next PATCH v2 10/10] net: netcp: support probe deferral Murali Karicheri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180327173509.GQ5862@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).