linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: cmc@babblebit.net (Chris Coffey)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] staging: mt7621-eth: Fix sparse warning in ethtool.c
Date: Thu, 29 Mar 2018 13:47:45 +0100	[thread overview]
Message-ID: <20180329124745.24694-1-cmc@babblebit.net> (raw)
In-Reply-To: <20180329095637.GA16778@kroah.com>

This fixes the following sparse warning:

drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol
'mtk_set_ethtool_ops' was not declared. Should it be static?

Signed-off-by: Chris Coffey <cmc@babblebit.net>
---
Changes in v2:
 - Per GregKH's feedback (thanks!), don't add unnecessary new .h file
 dependencies. This patch version reverts those changes and fixes the
 problem directly in ethtool.c (which is that it didn't include
 ethtool.h anywhere -- mtk_set_ethtool_ops is not static).

 drivers/staging/mt7621-eth/ethtool.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/mt7621-eth/ethtool.c b/drivers/staging/mt7621-eth/ethtool.c
index 38ba0c040a..5268c5ca09 100644
--- a/drivers/staging/mt7621-eth/ethtool.c
+++ b/drivers/staging/mt7621-eth/ethtool.c
@@ -13,6 +13,7 @@
  */
 
 #include "mtk_eth_soc.h"
+#include "ethtool.h"
 
 static const char mtk_gdma_str[][ETH_GSTRING_LEN] = {
 #define _FE(x...)	# x,
-- 
2.11.0

  reply	other threads:[~2018-03-29 12:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 21:18 [PATCH] staging: mt7621-eth: Fix sparse warning in ethtool.c Chris Coffey
2018-03-29  9:56 ` Greg Kroah-Hartman
2018-03-29 12:47   ` Chris Coffey [this message]
2018-04-01 23:34     ` [PATCH v2] " NeilBrown
2018-04-02  3:04       ` Sean Wang
2018-04-02  3:41         ` NeilBrown
2018-04-02 11:41           ` Christian Lütke-Stetzkamp
2018-04-02 22:39             ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180329124745.24694-1-cmc@babblebit.net \
    --to=cmc@babblebit.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).