From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: qcom-apq8064: disable i2c by default at soc dtsi
Date: Sun, 1 Apr 2018 14:32:10 -0700 [thread overview]
Message-ID: <20180401213210.GE510@tuxbook-pro> (raw)
In-Reply-To: <20180315144434.14095-1-srinivas.kandagatla@linaro.org>
On Thu 15 Mar 07:44 PDT 2018, Srinivas Kandagatla wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>
> This patch marks all the gsbi i2c node at soc level dtsi, so that kernel
> would not assume that its enabled and result in pin conflicts when gsbi
> is used for UART or SPI.
>
> Without this patch we see below pin conflict.
>
> apq8064-pinctrl 800000.pinctrl: pin GPIO_20 already requested by
> 12450000.serial; cannot claim for 12460000.i2c
> apq8064-pinctrl 800000.pinctrl: pin-20 (12460000.i2c) status -22
> apq8064-pinctrl 800000.pinctrl: could not request pin 20 (GPIO_20)
> from group gpio20 on device 800000.pinctrl
> i2c_qup 12460000.i2c: Error applying setting, reverse things back
> i2c_qup: probe of 12460000.i2c failed with error -22
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> arch/arm/boot/dts/qcom-apq8064.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index 3ca96e361878..54cff79f5725 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -444,6 +444,7 @@
> clock-names = "core", "iface";
> #address-cells = <1>;
> #size-cells = <0>;
> + status = "disabled";
> };
>
> };
> @@ -472,6 +473,7 @@
> clock-names = "core", "iface";
> #address-cells = <1>;
> #size-cells = <0>;
> + status = "disabled";
> };
> };
>
> @@ -497,6 +499,7 @@
> clock-names = "core", "iface";
> #address-cells = <1>;
> #size-cells = <0>;
> + status = "disabled";
> };
> };
>
> @@ -521,6 +524,7 @@
> clocks = <&gcc GSBI4_QUP_CLK>,
> <&gcc GSBI4_H_CLK>;
> clock-names = "core", "iface";
> + status = "disabled";
> };
> };
>
> --
> 2.16.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-04-01 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 14:44 [PATCH] ARM: dts: qcom-apq8064: disable i2c by default at soc dtsi srinivas.kandagatla at linaro.org
2018-04-01 21:32 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180401213210.GE510@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).