From mboxrd@z Thu Jan 1 00:00:00 1970 From: mylene.josserand@bootlin.com (=?UTF-8?B?TXlsw6huZQ==?= Josserand) Date: Tue, 3 Apr 2018 09:27:24 +0200 Subject: [PATCH v5 01/13] ARM: move cputype definitions into another file In-Reply-To: References: <20180403061836.3926-1-mylene.josserand@bootlin.com> <20180403061836.3926-2-mylene.josserand@bootlin.com> Message-ID: <20180403092724.607e8e37@dell-desktop.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chen-Yu, Thank you for your review! On Tue, 3 Apr 2018 14:52:45 +0800 Chen-Yu Tsai wrote: > On Tue, Apr 3, 2018 at 2:18 PM, Myl?ne Josserand > wrote: > > To add the support for SMP on sun8i-a83t, we will use some > > definitions in an assembly file so move definitions into > > another file to separate C functions and macro defintions. > > Instead of moving the definitions, you could guard all the C > stuff in "#ifndef __ASSEMBLY__". AFAIK a few header files do that. Oh, right. It is better with this check so I will use that in the next iteration of my series. Best regards, Myl?ne -- Myl?ne Josserand, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com > > ChenYu > > > Signed-off-by: Myl?ne Josserand > > --- > > arch/arm/include/asm/cputype.h | 94 +----------------------------------- > > arch/arm/include/asm/cputype_def.h | 98 ++++++++++++++++++++++++++++++++++++++