From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"
Date: Wed, 4 Apr 2018 13:24:26 +0300 [thread overview]
Message-ID: <20180404102425.cwj7vzvrvi2obcoi@mwanda> (raw)
In-Reply-To: <20180403134540.GA29017@lenoch>
On Tue, Apr 03, 2018 at 03:45:40PM +0200, Ladislav Michl wrote:
> On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
>
> Hello Colin,
>
> > Trivial fix to spelling mistake in pr_debug message text
>
> would you mind making this patch a bit less non-trivial and
> change pr_debug to dev_dbg dropping Atmel_ssc_dai prefix?
>
> Thank you.
>
Trivial patches should just be trivial instead of evolving into a thread
that lasts for days.
I sometimes write trivial clean up patches for things like:
arch/x86/lib/csum-partial_64.c:97 do_csum() warn: inconsistent indenting
88 /* last up to 7 8byte blocks */
89 count %= 8;
90 while (count) {
91 asm("addq %1,%0\n\t"
92 "adcq %2,%0\n"
93 : "=r" (result)
94 : "m" (*(unsigned long *)buff),
95 "r" (zero), "0" (result));
96 --count;
97 buff += 8;
98 }
Why is "buff += 8;" indented too far? And why does every line end in a
space character? And I think about it for 10 minutes and then delete my
patch because it's too much hassle to deal with for something small.
regards,
dan carpenter
next prev parent reply other threads:[~2018-04-04 10:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 15:44 [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping" Colin King
2018-03-31 8:54 ` Alexandre Belloni
2018-04-03 8:50 ` Nicolas Ferre
2018-04-03 13:45 ` [alsa-devel] " Ladislav Michl
2018-04-03 15:49 ` Joe Perches
2018-04-03 17:30 ` Ladislav Michl
2018-04-03 18:17 ` Joe Perches
2018-04-03 18:54 ` Ladislav Michl
2018-04-03 23:08 ` Joe Perches
2018-04-04 10:24 ` Dan Carpenter [this message]
2018-04-04 10:41 ` Colin Ian King
2018-04-04 12:30 ` Ladislav Michl
2018-04-04 14:46 ` Mark Brown
2018-04-12 16:16 ` Applied "ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"" to the asoc tree Mark Brown
2018-04-13 10:56 ` Mark Brown
2018-04-13 11:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404102425.cwj7vzvrvi2obcoi@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox