From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonathan.Cameron@huawei.com (Jonathan Cameron)
Date: Fri, 6 Apr 2018 16:13:22 +0100
Subject: [PATCH v2 07/10] input: touchscreen: touch_adc: add generic
 resistive ADC touchscreen
In-Reply-To: <20180330180911.GA143703@dtor-ws>
References: <1522153963-1121-1-git-send-email-eugen.hristev@microchip.com>
 <1522153963-1121-8-git-send-email-eugen.hristev@microchip.com>
 <20180330135835.6a8f57f1@archlinux>
 <20180330180911.GA143703@dtor-ws>
Message-ID: <20180406161322.00006190@huawei.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

> > > +
> > > +	input->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
> > > +	input->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
> > > +
> > > +	st->input = input;
> > > +	input_set_drvdata(input, st);
> > > +
> > > +	ret = input_register_device(input);
> > > +	if (ret) {
> > > +		dev_err(dev, "failed to register input device.");
> > > +		return ret;
> > > +	}
> > > +
> > > +	st->iio_cb = iio_channel_get_all_cb(&pdev->dev, grts_cb, st);  
> 
> Hmm, we don't have devm-variant for this? Then you could use
> devm_add_action_or_reset() to add cleanup action and completely remove
> grts_remove().
Not yet, but I'm not adverse to having one...