From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] Add tda998x (HDMI) support to atmel-hlcdc
Date: Mon, 9 Apr 2018 12:17:33 +0100 [thread overview]
Message-ID: <20180409111733.GP16141@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20180409105918.20792-1-peda@axentia.se>
On Mon, Apr 09, 2018 at 12:59:13PM +0200, Peter Rosin wrote:
> During this, I found that the tda998x driver never sets the format in
> the connector display_info. Thus, the atmel-hlcdc driver fails to select
> output format. Since I had similar problems with ds90c185 lvds encoder
> I added patches to override the atmel-hlcdc output format via a DT
> property and things start to play together.
That sounds like a hack. The tda998x driver doesn't set the format
because it pre-dates the addition of this information in the display
info structure, and none of its current users require that information.
As you're the first to require it, rather than working around the
driver by adding stuff to DT, it would be much better to improve the
driver by adding this information.
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2018-04-09 11:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 10:59 [PATCH 0/5] Add tda998x (HDMI) support to atmel-hlcdc Peter Rosin
2018-04-09 10:59 ` [PATCH 1/5] dt-bindings: display: bridge: lvds-transmitter: add ti, ds90c185 Peter Rosin
2018-04-13 17:39 ` [PATCH 1/5] dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185 Rob Herring
2018-04-09 10:59 ` [PATCH 2/5] dt-bindings: display: atmel: add optional output-mode property Peter Rosin
2018-04-13 17:46 ` Rob Herring
2018-04-14 13:54 ` Peter Rosin
2018-04-16 14:22 ` Rob Herring
2018-04-09 10:59 ` [PATCH 3/5] drm/atmel-hlcdc: allow overriding the output mode Peter Rosin
2018-04-09 10:59 ` [PATCH 4/5] drm/atmel-hlcdc: add support for connecting to tda998x HDMI encoder Peter Rosin
2018-04-09 10:59 ` [PATCH 5/5] drm/atmel-hlcdc: fix broken release date Peter Rosin
2018-04-09 11:17 ` Russell King - ARM Linux [this message]
2018-04-09 11:44 ` [PATCH 0/5] Add tda998x (HDMI) support to atmel-hlcdc Peter Rosin
2018-04-09 12:02 ` Russell King - ARM Linux
2018-04-09 12:12 ` Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409111733.GP16141@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).