From: marcin@ziemianowicz.com (Marcin Ziemianowicz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] clk: at91: Fix for PLL set_rate changes not being actually written to PLL peripheral bits
Date: Mon, 9 Apr 2018 20:16:49 -0400 [thread overview]
Message-ID: <20180410001649.GA62245@hak8or> (raw)
When a USB device is connected to the USB host port on the SAM9N12 then
you get "-62" error which seems to indicate USB replies from the device
are timing out. Looking around, I saw the USB bus was running at half
speed. Going further, it seems that in ..._set_rate() the PLL wasn't
actually being adjusted. Writing the multiplier and divider values to
the peripheral fixes the bus running at half speed.
Signed-off-by: Marcin Ziemianowicz <marcin@ziemianowicz.com>
---
drivers/clk/at91/clk-pll.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/clk/at91/clk-pll.c b/drivers/clk/at91/clk-pll.c
index 534961766ae5..db7155fe9346 100644
--- a/drivers/clk/at91/clk-pll.c
+++ b/drivers/clk/at91/clk-pll.c
@@ -288,6 +288,14 @@ static int clk_pll_set_rate(struct clk_hw *hw, unsigned long rate,
pll->div = div;
pll->mul = mul;
+ // Set the PLL as per above div and mil values.
+ regmap_update_bits(pll->regmap, AT91_CKGR_PLLBR,
+ AT91_PMC_DIV | AT91_PMC_MUL,
+ (div << 0) | (mul << 16));
+
+ pr_debug("clk-pll: setting new rate, (%lu hz / %u) * %u = %lu hz\n",
+ parent_rate, div, mul, rate);
+
return 0;
}
--
2.17.0
next reply other threads:[~2018-04-10 0:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 0:16 Marcin Ziemianowicz [this message]
2018-04-10 8:32 ` [PATCH v2 2/2] clk: at91: Fix for PLL set_rate changes not being actually written to PLL peripheral bits Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410001649.GA62245@hak8or \
--to=marcin@ziemianowicz.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).