From mboxrd@z Thu Jan 1 00:00:00 1970 From: christoffer.dall@arm.com (Christoffer Dall) Date: Tue, 17 Apr 2018 13:25:50 +0200 Subject: [PATCH] arm64: KVM: Demote SVE and LORegion warnings to debug only In-Reply-To: <20180417082356.19492-1-marc.zyngier@arm.com> References: <20180417082356.19492-1-marc.zyngier@arm.com> Message-ID: <20180417112550.GA62042@C02W217FHV2R.local> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Apr 17, 2018 at 09:23:56AM +0100, Marc Zyngier wrote: > While generating a message about guests probing for SVE/LORegions > is a useful debugging tool, considering it an error is slightly > over the top, as this is the only way the guest can find out > about the presence of the feature. > > Let's turn these message into kvm_debug so that they can only > be seen if CONFIG_DYNAMIC_DEBUG, and kept quiet otherwise. > > Signed-off-by: Marc Zyngier Acked-by: Christoffer Dall > --- > arch/arm64/kvm/sys_regs.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 806b0b126a64..6e3b969391fd 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -996,14 +996,12 @@ static u64 read_id_reg(struct sys_reg_desc const *r, bool raz) > > if (id == SYS_ID_AA64PFR0_EL1) { > if (val & (0xfUL << ID_AA64PFR0_SVE_SHIFT)) > - pr_err_once("kvm [%i]: SVE unsupported for guests, suppressing\n", > - task_pid_nr(current)); > + kvm_debug("SVE unsupported for guests, suppressing\n"); > > val &= ~(0xfUL << ID_AA64PFR0_SVE_SHIFT); > } else if (id == SYS_ID_AA64MMFR1_EL1) { > if (val & (0xfUL << ID_AA64MMFR1_LOR_SHIFT)) > - pr_err_once("kvm [%i]: LORegions unsupported for guests, suppressing\n", > - task_pid_nr(current)); > + kvm_debug("LORegions unsupported for guests, suppressing\n"); > > val &= ~(0xfUL << ID_AA64MMFR1_LOR_SHIFT); > } > -- > 2.14.2 >