From: maxime.ripard@bootlin.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: sunxi-ng: replace lib-y with obj-y
Date: Thu, 19 Apr 2018 15:42:21 +0200 [thread overview]
Message-ID: <20180419134221.ufsc462fw7j7so6q@flea> (raw)
In-Reply-To: <152409404578.51482.16644171573677016161@swboyd.mtv.corp.google.com>
On Wed, Apr 18, 2018 at 04:27:25PM -0700, Stephen Boyd wrote:
> Quoting Masahiro Yamada (2018-04-18 04:52:31)
> > We had commit 06e226c7fb23 ("clk: sunxi-ng: Move all clock types to a
> > library") and commit 799c43415442 ("kbuild: thin archives make default
> > for all archs") in the same development cycle, from different trees.
> >
> > With migration to the thin archive, the entire drivers/clk/sunxi-ng/lib.a
> > is linked to the vmlinux. This does not break build, but we do not get
> > any size saving.
> >
> > However, we do not need to go back to the individual Kconfig options.
> > The default configuration pulls in all (or most) of the CCU parts anyway.
> > Also, once we enable CONFIG_LD_DEAD_CODE_DATA_ELIMINATION, we can simply
> > list all files with obj-y, and the linker will drop all unused functions
> > by itself.
> >
> > After the long discussion [1], people there agreed to fix this, but
> > nobody sent a patch after all. I am doing it now.
> >
> > I lifted up CONFIG_SUNXI_CCU to drivers/clk/Makefile because everything
> > in drivers/clk/sunxi-ng/ depends on SUNXI_CCU.
> >
> > [1] https://patchwork.kernel.org/patch/9796521/
> >
> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> > ---
>
> Thanks for remembering to take care of this. I forgot about it all.
>
> Acked-by: Stephen Boyd <sboyd@kernel.org>
>
> Or I can pick this up directly. Let me know.
We'll probably have our usual round of patches that might generate
some conflicts on the Makefile. I've picked it up with your A-b, and
will send you a PR with it, as usual.
Thanks !
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180419/9c91da7d/attachment.sig>
next prev parent reply other threads:[~2018-04-19 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 11:52 [PATCH] clk: sunxi-ng: replace lib-y with obj-y Masahiro Yamada
2018-04-18 23:27 ` Stephen Boyd
2018-04-19 13:42 ` Maxime Ripard [this message]
2018-04-19 22:24 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419134221.ufsc462fw7j7so6q@flea \
--to=maxime.ripard@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox