From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty: serial: xuartps: Setup early console when uartclk is also passed
Date: Mon, 23 Apr 2018 10:06:41 +0200 [thread overview]
Message-ID: <20180423080641.GA20149@kroah.com> (raw)
In-Reply-To: <2ef5ac478f8d32bc807ead758eb5d60744a44515.1523367208.git.michal.simek@xilinx.com>
On Tue, Apr 10, 2018 at 03:33:30PM +0200, Michal Simek wrote:
> Baudrate calculation depends on requested baudrate and uart clock.
> This patch is checking that uartclk is also passed.
>
> The same logic is used 8250_early.c/init_port function.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> drivers/tty/serial/xilinx_uartps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index b9b2bc76bcac..a654cda203c7 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -1181,7 +1181,7 @@ static int __init cdns_early_console_setup(struct earlycon_device *device,
> /* only set baud if specified on command line - otherwise
> * assume it has been initialized by a boot loader.
> */
> - if (device->baud) {
> + if (port->uartclk && device->baud) {
> u32 cd = 0, bdiv = 0;
> u32 mr;
> int div8;
> --
> 1.9.1
This patch conflicts with the previous patch you sent: Subject: [PATCH]
serial: xuartps: Fix the early_console junk character issue
So, which one should I apply?
I've dropped both from my review queue now, please resend the one(s) you
want applied, in a patch series if needed.
thanks,
greg k-h
next prev parent reply other threads:[~2018-04-23 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 13:33 [PATCH] tty: serial: xuartps: Setup early console when uartclk is also passed Michal Simek
2018-04-23 8:06 ` Greg Kroah-Hartman [this message]
2018-04-23 8:37 ` Michal Simek
2018-04-23 8:48 ` Greg Kroah-Hartman
2018-04-23 8:52 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423080641.GA20149@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox