From: maxime.ripard@bootlin.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] ARM: dts: nes: add Nintendo NES/SuperNES Classic Edition support
Date: Tue, 24 Apr 2018 09:55:05 +0200 [thread overview]
Message-ID: <20180424075505.p6e43yw2juw4fqqw@flea> (raw)
In-Reply-To: <20180423122752.364ee649@xps13>
On Mon, Apr 23, 2018 at 12:27:52PM +0200, Miquel Raynal wrote:
> > > sun8i-r16-parrot.dtb \
> > > sun8i-r40-bananapi-m2-ultra.dtb \
> > > sun8i-v3s-licheepi-zero.dtb \
> > > diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> > > index 6b9e85b4ba0f..44f3cad3de75 100644
> > > --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> > > +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> > > @@ -198,6 +198,8 @@
> > > clock-names = "ahb", "mod";
> > > resets = <&ccu RST_BUS_NAND>;
> > > reset-names = "ahb";
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&nand_pins &nand_pins_cs0 &nand_pins_rb0>;
> >
> > This should be in your first patch I guess?
>
> Actually I think this should not be there but instead, because it is
> board-related, these two lines should be in the nes-classic.dts' nfc
> node, right? Other a23/a33/r16 based designs could use the second set
> of CS/RB pins.
Does that ever happen?
On a theoretical level, then yeah, sure. But if all the boards seen
out there are using the same setup (which is pretty common), then
there's no reason not to do it in the DTSI.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180424/522f47ed/attachment.sig>
next prev parent reply other threads:[~2018-04-24 7:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 16:42 [PATCH v3 0/2] Add Nintendo NES/SuperNES classic support Miquel Raynal
2018-04-21 16:42 ` [PATCH v3 1/2] ARM: dts: sun8i: a23/a33: declare NAND pins Miquel Raynal
2018-04-21 16:42 ` [PATCH v3 2/2] ARM: dts: nes: add Nintendo NES/SuperNES Classic Edition support Miquel Raynal
2018-04-23 7:24 ` Maxime Ripard
2018-04-23 10:27 ` Miquel Raynal
2018-04-24 7:55 ` Maxime Ripard [this message]
2018-04-24 8:05 ` Miquel Raynal
2018-04-24 8:49 ` Miquel Raynal
2018-04-24 9:16 ` Miquel Raynal
2018-04-24 11:05 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424075505.p6e43yw2juw4fqqw@flea \
--to=maxime.ripard@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox