From: manivannan.sadhasivam@linaro.org (Manivannan Sadhasivam)
To: linux-arm-kernel@lists.infradead.org
Subject: [dragonboard] [PATCH 1/1] dts: qcom: db820c: Add gpio-line-names property
Date: Thu, 26 Apr 2018 19:01:45 +0530 [thread overview]
Message-ID: <20180426133145.24dfnfarnuunf2wy@mani> (raw)
In-Reply-To: <CACRpkdZxwz5=oTxGWBgVHfy-D9s-f03qqjypUeJj6GrpXQcEcQ@mail.gmail.com>
Hi Linus,
On Thu, Apr 26, 2018 at 03:23:57PM +0200, Linus Walleij wrote:
> On Mon, Apr 16, 2018 at 12:03 PM, Manivannan Sadhasivam
> <manivannan.sadhasivam@linaro.org> wrote:
> > On Mon, Apr 16, 2018 at 11:48:59AM +0300, Todor Tomov wrote:
>
> >> > + * When the 96Board naming of a line and the schematic name of
> >> > + * the same line are in conflict, the 96Board specification
> >> > + * takes precedence, which means that the external UART on the
> >> > + * LSEC is named UART0 while the schematic and SoC names this
> >> > + * UART3. This is only for the informational lines i.e. "[FOO]",
> >>
> >> It seems to me that this can lead to some confusion for cases when
> >> some schematic names have 96board names and others don't. (An
> >> example below.) However I don't really see any better way to do
> >> it. I'm wondering whether adding the schematic name in
> >> the comment (for gpios which are named with 96board names)
> >> can help a little. What do you think? Or any other idea?
> >>
> >
> > Specifying the schematic names in comments is a good idea!
> >
> > Linus: Do you have any suggestion here?
>
> Go for this.
>
Thanks!
> Generally ask the question: what does the user need?
>
> In this case, especially userspace libraries like mriaa (right name?)
MRAA :)
> should be able to work out-of-the-box without knowing what
> board it is but know it has a 96board connector.
>
I have sent out v2, incorporating the review comments from Todor.
Can you please review it?
Thanks,
Mani
> Yours,
> Linus Walleij
prev parent reply other threads:[~2018-04-26 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 3:18 [PATCH 0/1] Add gpio-line-names property for Dragonboard820c Manivannan Sadhasivam
2018-04-14 3:18 ` [PATCH 1/1] dts: qcom: db820c: Add gpio-line-names property Manivannan Sadhasivam
2018-04-16 8:48 ` [dragonboard] " Todor Tomov
2018-04-16 10:03 ` Manivannan Sadhasivam
2018-04-26 13:23 ` Linus Walleij
2018-04-26 13:31 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426133145.24dfnfarnuunf2wy@mani \
--to=manivannan.sadhasivam@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox