From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] iio: adc: stm32-dfsdm: add check on max filter id
Date: Sat, 28 Apr 2018 16:07:06 +0100 [thread overview]
Message-ID: <20180428160706.2aafad5b@archlinux> (raw)
In-Reply-To: <1519390261-25453-7-git-send-email-fabrice.gasnier@st.com>
On Fri, 23 Feb 2018 13:51:00 +0100
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:
> reg property should be checked against number of available filters.
> BTW, dfsdm->num_fls wasn't used. But it can be used for this purpose.
> This prevents using data out of allocated dfsdm->fl_list array.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/stm32-dfsdm-adc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 57bcb45..1b78bec 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -1111,8 +1111,8 @@ static int stm32_dfsdm_adc_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, adc);
>
> ret = of_property_read_u32(dev->of_node, "reg", &adc->fl_id);
> - if (ret != 0) {
> - dev_err(dev, "Missing reg property\n");
> + if (ret != 0 || adc->fl_id >= adc->dfsdm->num_fls) {
> + dev_err(dev, "Missing or bad reg property\n");
> return -EINVAL;
> }
>
next prev parent reply other threads:[~2018-04-28 15:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 12:50 [PATCH 0/7] iio: adc: stm32-dfsdm: misc fixes and improvements Fabrice Gasnier
2018-02-23 12:50 ` [PATCH 1/7] iio: adc: stm32-dfsdm: fix compatible data use Fabrice Gasnier
2018-02-24 12:56 ` Jonathan Cameron
2018-02-23 12:50 ` [PATCH 2/7] iio: adc: stm32-dfsdm: fix call to stop channel Fabrice Gasnier
2018-02-24 12:57 ` Jonathan Cameron
2018-02-23 12:50 ` [PATCH 3/7] iio: adc: stm32-dfsdm: fix clock source selection Fabrice Gasnier
2018-02-24 12:59 ` Jonathan Cameron
2018-02-23 12:50 ` [PATCH 4/7] iio: adc: stm32-dfsdm: fix multiple channel initialization Fabrice Gasnier
2018-02-24 13:01 ` Jonathan Cameron
2018-02-23 12:50 ` [PATCH 5/7] iio: adc: stm32-dfsdm: misc style improvements and fixes Fabrice Gasnier
2018-02-24 13:03 ` Jonathan Cameron
2018-02-27 8:21 ` Fabrice Gasnier
2018-03-03 15:09 ` Jonathan Cameron
2018-04-23 7:48 ` Fabrice Gasnier
2018-04-28 14:52 ` Jonathan Cameron
2018-02-23 12:51 ` [PATCH 6/7] iio: adc: stm32-dfsdm: add check on max filter id Fabrice Gasnier
2018-04-28 15:07 ` Jonathan Cameron [this message]
2018-02-23 12:51 ` [PATCH 7/7] iio: adc: stm32-dfsdm: add check on spi-max-frequency Fabrice Gasnier
2018-04-28 15:07 ` Jonathan Cameron
2018-02-23 13:49 ` [PATCH 0/7] iio: adc: stm32-dfsdm: misc fixes and improvements Arnaud Pouliquen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180428160706.2aafad5b@archlinux \
--to=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox