From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@bootlin.com (Maxime Ripard) Date: Wed, 2 May 2018 13:49:24 +0200 Subject: [linux-sunxi] Re: [PATCH 02/21] arm64: dts: allwinner: a64: Add DE2 CCU In-Reply-To: References: <20180430114058.5061-1-jagan@amarulasolutions.com> <20180430114058.5061-3-jagan@amarulasolutions.com> <20180502113250.5i2eyzv237t5oyl6@flea> Message-ID: <20180502114924.pq5k5p33svedgca4@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, May 02, 2018 at 07:34:21PM +0800, Icenowy Zheng wrote: > > > ? 2018?5?2? GMT+08:00 ??7:32:50, Maxime Ripard ??: > >On Mon, Apr 30, 2018 at 05:10:39PM +0530, Jagan Teki wrote: > >> DE2 in A64 has clock control unit and behavior is > >> same like H3/H5, so reuse the same in A64. > >> > >> Signed-off-by: Jagan Teki > >> --- > >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 15 +++++++++++++++ > >> 1 file changed, 15 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> index 1b2ef28c42bd..67b80bbe5bf5 100644 > >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > >> @@ -43,9 +43,11 @@ > >> */ > >> > >> #include > >> +#include > >> #include > >> #include > >> #include > >> +#include > >> > >> / { > >> interrupt-parent = <&gic>; > >> @@ -168,6 +170,19 @@ > >> #size-cells = <1>; > >> ranges; > >> > >> + display_clocks: clock at 1000000 { > >> + compatible = "allwinner,sun50i-a64-de2-clk", > >> + "allwinner,sun50i-h5-de2-clk"; > > > >The A64 was released before the H5, so that should be the other way > >around. > > > >> + reg = <0x01000000 0x100000>; > >> + clocks = <&ccu CLK_DE>, > >> + <&ccu CLK_BUS_DE>; > >> + clock-names = "mod", > >> + "bus"; > >> + resets = <&ccu RST_BUS_DE>; > >> + #clock-cells = <1>; > >> + #reset-cells = <1>; > >> + }; > >> + > > > >So it turns out we don't need the SRAM to access the CCU driver? > > As now U-Boot claims SRAM, people may forget thus :-( This is definitely not ok. We should have that described in the DT as well. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: