From: leo.yan@linaro.org (Leo Yan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] hisi: Consolidate the Kconfigs for the CLOCK_STUB and the MAILBOX
Date: Fri, 4 May 2018 22:19:20 +0800 [thread overview]
Message-ID: <20180504141920.GA17313@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <1522811675-12741-6-git-send-email-leo.yan@linaro.org>
On Wed, Apr 04, 2018 at 11:14:35AM +0800, Leo Yan wrote:
> From: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> The current defconfig is inconsistent as it selects the mailbox and
> the clock for the hi6220 and the hi3660 without having their Kconfigs
> making sure the dependencies are correct. It ends up when selecting
> different versions for the kernel (for example when git bisecting)
> those options disappear and they don't get back, leading to unexpected
> behaviors. In our case, the cpufreq driver does no longer work because
> the clock fails to initialize due to the clock stub and the mailbox
> missing.
>
> In order to have the dependencies correctly set when defaulting, let's
> do the same as commit 3a49afb84ca074e ("clk: enable hi655x common clk
> automatically") where we select automatically the driver when the
> parent driver is selected. With sensible defaults in place, we can leave
> other choices for EXPERT.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Hi Jassi,
Could you review and ack for this patch?
Hi Wei,
Stephen has acked this patch and if we can get ack from Jassi, could
you pick up this patch?
I missed my Signed-off-by tag, this might break the chain.
So when you pick up this patch, please add my Signed-off-by tag:
Signed-off-by: Leo Yan <leo.yan@linaro.org>
Thanks,
Leo Yan
next prev parent reply other threads:[~2018-05-04 14:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 3:14 [PATCH 0/5] Hi3660: enable power management features Leo Yan
2018-04-04 3:14 ` [PATCH 1/5] dts: arm64: hi3660: Add mailbox node Leo Yan
2018-04-04 3:14 ` [PATCH 2/5] dts: arm64: hi3660: Add stub clock node Leo Yan
2018-04-04 3:14 ` [PATCH 3/5] dts: arm64: hi3660: Add CPU frequency scaling support Leo Yan
2018-04-04 3:14 ` [PATCH 4/5] dts: arm64: hi3660: Add thermal cooling management Leo Yan
2018-04-04 3:14 ` [PATCH 5/5] hisi: Consolidate the Kconfigs for the CLOCK_STUB and the MAILBOX Leo Yan
2018-04-07 12:56 ` Stephen Boyd
2018-05-04 14:19 ` Leo Yan [this message]
2018-05-09 3:49 ` Jassi Brar
2018-05-09 4:02 ` Leo Yan
2018-05-11 14:05 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504141920.GA17313@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox