linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] ARM: dtd: Set DNS-313 LEDs to use better triggers
Date: Sun,  6 May 2018 15:43:47 +0200	[thread overview]
Message-ID: <20180506134352.2637-3-linus.walleij@linaro.org> (raw)
In-Reply-To: <20180506134352.2637-1-linus.walleij@linaro.org>

We just used one LED for "disk activity" but using the green
LED for disk read and the red LED for disk write gives a way
better user experience.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/boot/dts/gemini-dlink-dns-313.dts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
index 55b294f1675c..2d9aa5ba8320 100644
--- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts
+++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
@@ -59,14 +59,13 @@
 			label = "dns313:green:disk";
 			gpios = <&gpio0 3 GPIO_ACTIVE_HIGH>;
 			default-state = "off";
-			linux,default-trigger = "ide-disk";
-			/* Ideally should activate while reading */
+			linux,default-trigger = "disk-read";
 		};
 		led-disk-red {
 			label = "dns313:red:disk";
 			gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>;
 			default-state = "off";
-			/* Ideally should activate while writing */
+			linux,default-trigger = "disk-write";
 		};
 	};
 
-- 
2.17.0

  parent reply	other threads:[~2018-05-06 13:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-06 13:43 [PATCH 0/7] Gemini DTS updates Linus Walleij
2018-05-06 13:43 ` [PATCH 1/7] ARM: dts: gemini: Fix "debounce-interval" property misspelling Linus Walleij
2018-05-06 13:43 ` Linus Walleij [this message]
2018-05-06 13:43 ` [PATCH 3/7] ARM: dts: Set DNS-685 LEDs to use better triggers Linus Walleij
2018-05-06 13:43 ` [PATCH 4/7] ARM: dts: Fix the DNS-313 flash compatible Linus Walleij
2018-05-06 13:43 ` [PATCH 5/7] ARM: dts: Fix bootargs for Gemini D-Link devices Linus Walleij
2018-05-06 13:43 ` [PATCH 6/7] ARM: dts: Add second ATA to NAS4220B Linus Walleij
2018-05-06 13:43 ` [PATCH 7/7] ARM: dts: Fix DTC warnings Linus Walleij
2018-05-08 10:37   ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180506134352.2637-3-linus.walleij@linaro.org \
    --to=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).