linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jacopo@jmondi.org (jacopo mondi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: r8a7740: Add CEU1
Date: Tue, 15 May 2018 09:21:32 +0200	[thread overview]
Message-ID: <20180515072132.GP5956@w540> (raw)
In-Reply-To: <20180515071006.vmtxzwrppzrgekmf@verge.net.au>

Hi Simon,

On Tue, May 15, 2018 at 09:10:06AM +0200, Simon Horman wrote:
> On Mon, May 07, 2018 at 02:37:57PM +0200, Simon Horman wrote:
> > Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Would anyone care to review this change?

That would be me, as I've sent patches for CEU0 on R-Mobile A1, sorry
about that.

>
> > ---
> >  arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> >  Depends and based on:
> >  "[PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0"
> >
> > diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
> > index 508d93440ee8..af4c071c9178 100644
> > --- a/arch/arm/boot/dts/r8a7740.dtsi
> > +++ b/arch/arm/boot/dts/r8a7740.dtsi
> > @@ -77,6 +77,16 @@
> >  		status = "disabled";
> >  	};
> >
> > +	ceu1: ceu at fe914000 {
> > +		reg = <0xfe910000 0x3000>;

The reg property start address does not match the device node unit
address (which is the correct one according to documentation).

Thanks
   j

> > +		compatible = "renesas,r8a7740-ceu";
> > +		interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
> > +		clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
> > +		clock-names = "ceu21";
> > +		power-domains = <&pd_a4r>;
> > +		status = "disabled";
> > +	};
> > +
> >  	cmt1: timer at e6138000 {
> >  		compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48";
> >  		reg = <0xe6138000 0x170>;
> > --
> > 2.11.0
> >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180515/865bbda0/attachment.sig>

  reply	other threads:[~2018-05-15  7:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 12:37 [PATCH] ARM: dts: r8a7740: Add CEU1 Simon Horman
2018-05-15  7:10 ` Simon Horman
2018-05-15  7:21   ` jacopo mondi [this message]
2018-05-15  8:01     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180515072132.GP5956@w540 \
    --to=jacopo@jmondi.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).