* [PATCH] ARM: dts: r8a7740: Add CEU1
@ 2018-05-07 12:37 Simon Horman
2018-05-15 7:10 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2018-05-07 12:37 UTC (permalink / raw)
To: linux-arm-kernel
Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
Depends and based on:
"[PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0"
diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
index 508d93440ee8..af4c071c9178 100644
--- a/arch/arm/boot/dts/r8a7740.dtsi
+++ b/arch/arm/boot/dts/r8a7740.dtsi
@@ -77,6 +77,16 @@
status = "disabled";
};
+ ceu1: ceu at fe914000 {
+ reg = <0xfe910000 0x3000>;
+ compatible = "renesas,r8a7740-ceu";
+ interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
+ clock-names = "ceu21";
+ power-domains = <&pd_a4r>;
+ status = "disabled";
+ };
+
cmt1: timer at e6138000 {
compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48";
reg = <0xe6138000 0x170>;
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: r8a7740: Add CEU1
2018-05-07 12:37 [PATCH] ARM: dts: r8a7740: Add CEU1 Simon Horman
@ 2018-05-15 7:10 ` Simon Horman
2018-05-15 7:21 ` jacopo mondi
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2018-05-15 7:10 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 07, 2018 at 02:37:57PM +0200, Simon Horman wrote:
> Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Would anyone care to review this change?
> ---
> arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> Depends and based on:
> "[PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0"
>
> diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
> index 508d93440ee8..af4c071c9178 100644
> --- a/arch/arm/boot/dts/r8a7740.dtsi
> +++ b/arch/arm/boot/dts/r8a7740.dtsi
> @@ -77,6 +77,16 @@
> status = "disabled";
> };
>
> + ceu1: ceu at fe914000 {
> + reg = <0xfe910000 0x3000>;
> + compatible = "renesas,r8a7740-ceu";
> + interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
> + clock-names = "ceu21";
> + power-domains = <&pd_a4r>;
> + status = "disabled";
> + };
> +
> cmt1: timer at e6138000 {
> compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48";
> reg = <0xe6138000 0x170>;
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: r8a7740: Add CEU1
2018-05-15 7:10 ` Simon Horman
@ 2018-05-15 7:21 ` jacopo mondi
2018-05-15 8:01 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: jacopo mondi @ 2018-05-15 7:21 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Tue, May 15, 2018 at 09:10:06AM +0200, Simon Horman wrote:
> On Mon, May 07, 2018 at 02:37:57PM +0200, Simon Horman wrote:
> > Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Would anyone care to review this change?
That would be me, as I've sent patches for CEU0 on R-Mobile A1, sorry
about that.
>
> > ---
> > arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > Depends and based on:
> > "[PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0"
> >
> > diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
> > index 508d93440ee8..af4c071c9178 100644
> > --- a/arch/arm/boot/dts/r8a7740.dtsi
> > +++ b/arch/arm/boot/dts/r8a7740.dtsi
> > @@ -77,6 +77,16 @@
> > status = "disabled";
> > };
> >
> > + ceu1: ceu at fe914000 {
> > + reg = <0xfe910000 0x3000>;
The reg property start address does not match the device node unit
address (which is the correct one according to documentation).
Thanks
j
> > + compatible = "renesas,r8a7740-ceu";
> > + interrupts = <GIC_SPI 159 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&mstp1_clks R8A7740_CLK_CEU21>;
> > + clock-names = "ceu21";
> > + power-domains = <&pd_a4r>;
> > + status = "disabled";
> > + };
> > +
> > cmt1: timer at e6138000 {
> > compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48";
> > reg = <0xe6138000 0x170>;
> > --
> > 2.11.0
> >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180515/865bbda0/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] ARM: dts: r8a7740: Add CEU1
2018-05-15 7:21 ` jacopo mondi
@ 2018-05-15 8:01 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2018-05-15 8:01 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 15, 2018 at 09:21:32AM +0200, jacopo mondi wrote:
> Hi Simon,
>
> On Tue, May 15, 2018 at 09:10:06AM +0200, Simon Horman wrote:
> > On Mon, May 07, 2018 at 02:37:57PM +0200, Simon Horman wrote:
> > > Describe CEU1 peripheral for Renesas R-Mobile A1 R8A7740 Soc.
> > >
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > Would anyone care to review this change?
>
> That would be me, as I've sent patches for CEU0 on R-Mobile A1, sorry
> about that.
No problem :)
> > > ---
> > > arch/arm/boot/dts/r8a7740.dtsi | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > >
> > > Depends and based on:
> > > "[PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0"
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
> > > index 508d93440ee8..af4c071c9178 100644
> > > --- a/arch/arm/boot/dts/r8a7740.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7740.dtsi
> > > @@ -77,6 +77,16 @@
> > > status = "disabled";
> > > };
> > >
> > > + ceu1: ceu at fe914000 {
> > > + reg = <0xfe910000 0x3000>;
>
> The reg property start address does not match the device node unit
> address (which is the correct one according to documentation).
Thanks, v2 posted.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-15 8:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-07 12:37 [PATCH] ARM: dts: r8a7740: Add CEU1 Simon Horman
2018-05-15 7:10 ` Simon Horman
2018-05-15 7:21 ` jacopo mondi
2018-05-15 8:01 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).