From: vkoul@kernel.org (Vinod)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: qcom: bam_dma: fix some doc warnings.
Date: Thu, 17 May 2018 16:25:17 +0530 [thread overview]
Message-ID: <20180517105517.GA13271@vkoul-mobl> (raw)
In-Reply-To: <c3b63215-ed0f-93ee-69df-6b22053f0479@linaro.org>
On 17-05-18, 11:53, Srinivas Kandagatla wrote:
>
>
> On 17/05/18 11:50, Vinod Koul wrote:
> > On 17-05-18, 10:59, Srinivas Kandagatla wrote:
> > > diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
> > > index 4a828c18099a..a05fff8a1447 100644
> > > --- a/drivers/dma/qcom/bam_dma.c
> > > +++ b/drivers/dma/qcom/bam_dma.c
> > > @@ -451,7 +451,7 @@ static void bam_reset_channel(struct bam_chan *bchan)
> > > /**
> > > * bam_chan_init_hw - Initialize channel hardware
> > > * @bchan: bam channel
> > > - *
> > > + * @dir: DMA transfer direction
> >
> > Do you want to add an empty line here?
> >
> TBH, Am not 100% sure it it adds any value.
>
> Most of the function docs in the file have this same issue.. :-)
>
> let me know if you still want an empty line, I can respin.
Yeah that's why asked, I can edit while applying so no issues
--
~Vinod
next prev parent reply other threads:[~2018-05-17 10:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 9:59 [PATCH] dmaengine: qcom: bam_dma: fix some doc warnings Srinivas Kandagatla
2018-05-17 9:59 ` [PATCH] dmaengine: qcom: bam_dma: fix invalid assignment warning Srinivas Kandagatla
2018-05-17 10:50 ` [PATCH] dmaengine: qcom: bam_dma: fix some doc warnings Vinod Koul
2018-05-17 10:53 ` Srinivas Kandagatla
2018-05-17 10:55 ` Vinod [this message]
2018-05-17 10:56 ` Srinivas Kandagatla
2018-05-17 10:59 ` Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517105517.GA13271@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox