* [PATCH] ARM: davinci: board-da850-evm: fix WP pin polarity for MMC/SD
@ 2018-05-18 1:20 Adam Ford
2018-06-26 14:39 ` Sekhar Nori
0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2018-05-18 1:20 UTC (permalink / raw)
To: linux-arm-kernel
When booting from MMC/SD in rw mode, the system crashes because
the write protect pin should be active high and not active low.
This patch fixes the polarity of the WP pin.
Fixes: 67c6b6ff221f ("ARM: davinci: board-da850-evm: fix GPIO
lookup for MMC/SD")
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
index e22fb40e34bc..6d5beb11bd96 100644
--- a/arch/arm/mach-davinci/board-da850-evm.c
+++ b/arch/arm/mach-davinci/board-da850-evm.c
@@ -774,7 +774,7 @@ static struct gpiod_lookup_table mmc_gpios_table = {
GPIO_LOOKUP("davinci_gpio.0", DA850_MMCSD_CD_PIN, "cd",
GPIO_ACTIVE_LOW),
GPIO_LOOKUP("davinci_gpio.0", DA850_MMCSD_WP_PIN, "wp",
- GPIO_ACTIVE_LOW),
+ GPIO_ACTIVE_HIGH),
},
};
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: davinci: board-da850-evm: fix WP pin polarity for MMC/SD
2018-05-18 1:20 [PATCH] ARM: davinci: board-da850-evm: fix WP pin polarity for MMC/SD Adam Ford
@ 2018-06-26 14:39 ` Sekhar Nori
0 siblings, 0 replies; 2+ messages in thread
From: Sekhar Nori @ 2018-06-26 14:39 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 18 May 2018 06:50 AM, Adam Ford wrote:
> When booting from MMC/SD in rw mode, the system crashes because
... in rw mode on DA850 EVM, ..
> the write protect pin should be active high and not active low.
> This patch fixes the polarity of the WP pin.
>
> Fixes: 67c6b6ff221f ("ARM: davinci: board-da850-evm: fix GPIO
> lookup for MMC/SD")
Fixes: bdf0e8364fd3 ("ARM: davinci: da850-evm: use gpio descriptor for mmc pins")
is more appropriate since thats where the bug was actually introduced
and thats how far back you want the patch backported.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
With these changes, applied to fixes for v4.18.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-26 14:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-18 1:20 [PATCH] ARM: davinci: board-da850-evm: fix WP pin polarity for MMC/SD Adam Ford
2018-06-26 14:39 ` Sekhar Nori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).