linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] omap2: powerdomain: Inroduce cpu_pm notifiers for context save/restore
Date: Fri, 18 May 2018 06:54:58 -0700	[thread overview]
Message-ID: <20180518135458.GU98604@atomide.com> (raw)
In-Reply-To: <67b3758f-8616-22ab-786e-206f7e5de020@ti.com>

* Tero Kristo <t-kristo@ti.com> [180518 07:02]:
> On 18/05/18 07:32, Keerthy wrote:
> > 
> > 
> > On Friday 18 May 2018 03:15 AM, Tony Lindgren wrote:
> > > * Keerthy <j-keerthy@ti.com> [180516 15:21]:
> > > > +	/* Only AM43XX can lose pwrdm context during rtc-ddr suspend */
> > > > +	if (soc_is_am43xx()) {
> > > > +		nb.notifier_call = cpu_notifier;
> > > > +		cpu_pm_register_notifier(&nb);
> > > > +	}
> > > > +
> > > 
> > > Hmm in patch 3/4 you add omap4_pwrdm_save_context(), I think
> > > that we'd want to run with the notifier for cpuidle on omap4?
> > 
> > Okay i believe that is not needed for cpuidle on omap4. PRCM on wakeup
> > domain so save/restore not needed for powerdomain on omap4.
> > 
> > Tero can confirm the same.
> 
> Yea I don't believe this is needed. Only certain portions of the OMAP4 PRCM
> lose context during device off mode (which is currently not supported by
> linux), and whatever portions do lose, they should use the SAR_RAM approach
> for context save/restore, as that is supported by HW/ROM code.

OK

> > Should i rename omap4_pwrdm_save_context to am43xx_pwrdm_save_context to
> > avoid confusion?

No need to, it follows the naming prm44xx.c.

Regards,

Tony

      reply	other threads:[~2018-05-18 13:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-16 15:16 [PATCH 0/4] arm: mach-omap2: clkdm/pwrdm: Save/restore context Keerthy
2018-05-16 15:16 ` [PATCH 1/4] ARM: OMAP2: Add functions to save and restore clockdomain context en-masse Keerthy
2018-05-16 15:16 ` [PATCH 2/4] omap2: clockdomain: Inroduce cpu_pm notifiers for context save/restore Keerthy
2018-05-17 21:43   ` Tony Lindgren
2018-05-18  5:57     ` Keerthy
2018-05-18  8:38       ` Tero Kristo
2018-05-18 13:54         ` Tony Lindgren
2018-05-16 15:17 ` [PATCH 3/4] ARM: OMAP2: Add functions to save and restore powerdomain context Keerthy
2018-05-16 15:17 ` [PATCH 4/4] omap2: powerdomain: Inroduce cpu_pm notifiers for context save/restore Keerthy
2018-05-17 21:45   ` Tony Lindgren
2018-05-18  4:32     ` Keerthy
2018-05-18  7:00       ` Tero Kristo
2018-05-18 13:54         ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180518135458.GU98604@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).