From mboxrd@z Thu Jan  1 00:00:00 1970
From: tony@atomide.com (Tony Lindgren)
Date: Fri, 18 May 2018 06:54:58 -0700
Subject: [PATCH 4/4] omap2: powerdomain: Inroduce cpu_pm notifiers for
 context save/restore
In-Reply-To: <67b3758f-8616-22ab-786e-206f7e5de020@ti.com>
References: <1526483821-25585-1-git-send-email-j-keerthy@ti.com>
 <1526483821-25585-5-git-send-email-j-keerthy@ti.com>
 <20180517214507.GS98604@atomide.com>
 <7df065c3-5154-5059-891c-2855e3cdbe00@ti.com>
 <67b3758f-8616-22ab-786e-206f7e5de020@ti.com>
Message-ID: <20180518135458.GU98604@atomide.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

* Tero Kristo <t-kristo@ti.com> [180518 07:02]:
> On 18/05/18 07:32, Keerthy wrote:
> > 
> > 
> > On Friday 18 May 2018 03:15 AM, Tony Lindgren wrote:
> > > * Keerthy <j-keerthy@ti.com> [180516 15:21]:
> > > > +	/* Only AM43XX can lose pwrdm context during rtc-ddr suspend */
> > > > +	if (soc_is_am43xx()) {
> > > > +		nb.notifier_call = cpu_notifier;
> > > > +		cpu_pm_register_notifier(&nb);
> > > > +	}
> > > > +
> > > 
> > > Hmm in patch 3/4 you add omap4_pwrdm_save_context(), I think
> > > that we'd want to run with the notifier for cpuidle on omap4?
> > 
> > Okay i believe that is not needed for cpuidle on omap4. PRCM on wakeup
> > domain so save/restore not needed for powerdomain on omap4.
> > 
> > Tero can confirm the same.
> 
> Yea I don't believe this is needed. Only certain portions of the OMAP4 PRCM
> lose context during device off mode (which is currently not supported by
> linux), and whatever portions do lose, they should use the SAR_RAM approach
> for context save/restore, as that is supported by HW/ROM code.

OK

> > Should i rename omap4_pwrdm_save_context to am43xx_pwrdm_save_context to
> > avoid confusion?

No need to, it follows the naming prm44xx.c.

Regards,

Tony