* [PATCH] firmware: arm_scmi: remove some unnecessary checks
@ 2018-05-19 6:37 Dan Carpenter
2018-05-23 16:59 ` Sudeep Holla
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-05-19 6:37 UTC (permalink / raw)
To: linux-arm-kernel
The "pi->dom_info" buffer is allocated in init() and it can't be NULL
here. These tests are sort of weird as well because if "pi->dom_info"
was NULL but "domain" was non-zero then it would lead to an Oops.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
index 2a219b1261b1..721e6c57beae 100644
--- a/drivers/firmware/arm_scmi/perf.c
+++ b/drivers/firmware/arm_scmi/perf.c
@@ -363,8 +363,6 @@ static int scmi_dvfs_device_opps_add(const struct scmi_handle *handle,
return domain;
dom = pi->dom_info + domain;
- if (!dom)
- return -EIO;
for (opp = dom->opp, idx = 0; idx < dom->opp_count; idx++, opp++) {
freq = opp->perf * dom->mult_factor;
@@ -394,9 +392,6 @@ static int scmi_dvfs_transition_latency_get(const struct scmi_handle *handle,
return domain;
dom = pi->dom_info + domain;
- if (!dom)
- return -EIO;
-
/* uS to nS */
return dom->opp[dom->opp_count - 1].trans_latency_us * 1000;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] firmware: arm_scmi: remove some unnecessary checks
2018-05-19 6:37 [PATCH] firmware: arm_scmi: remove some unnecessary checks Dan Carpenter
@ 2018-05-23 16:59 ` Sudeep Holla
0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2018-05-23 16:59 UTC (permalink / raw)
To: linux-arm-kernel
On 19/05/18 07:37, Dan Carpenter wrote:
> The "pi->dom_info" buffer is allocated in init() and it can't be NULL
> here. These tests are sort of weird as well because if "pi->dom_info"
> was NULL but "domain" was non-zero then it would lead to an Oops.
>
Indeed. Thanks for the patch.
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-23 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-19 6:37 [PATCH] firmware: arm_scmi: remove some unnecessary checks Dan Carpenter
2018-05-23 16:59 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).