[xlnx:xlnx_rebase_v4.14 937/937] drivers/clk/idt/clk-idt8t49n24x-core.c:50:4: sparse: symbol 'q0_ns1_options' was not declared. Should it be static?

[xlnx:xlnx_rebase_v4.14 937/937] drivers/clk/idt/clk-idt8t49n24x-core.c:50:4: sparse: symbol 'q0_ns1_options' was not declared. Should it be static?

[kbuild test robot]

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v4.14
head:   6588700bdabc9bb1a0156770ed2ac41da7d823dd
commit: 6588700bdabc9bb1a0156770ed2ac41da7d823dd [937/937] clk: Add ccf driver for IDT 8T49N24x UFT
reproduce:
        # apt-get install sparse
        git checkout 6588700bdabc9bb1a0156770ed2ac41da7d823dd
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/clk/idt/clk-idt8t49n24x-core.c:50:4: sparse: symbol 'q0_ns1_options' was not declared. Should it be static?
>> drivers/clk/idt/clk-idt8t49n24x-core.c:691:9: sparse: right shift by bigger than source value
   drivers/clk/idt/clk-idt8t49n24x-core.c:696:39: sparse: right shift by bigger than source value
--
>> drivers/clk/idt/clk-idt8t49n24x-debugfs.c:19:24: sparse: symbol 'idt24x_chip_fordebugfs' was not declared. Should it be static?
>> drivers/clk/idt/clk-idt8t49n24x-debugfs.c:246:47: sparse: dereference of noderef expression
   drivers/clk/idt/clk-idt8t49n24x-debugfs.c:247:32: sparse: dereference of noderef expression

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[RFC PATCH xlnx] clk: q0_ns1_options[] can be static

[kbuild test robot]

Fixes: 6588700bdabc ("clk: Add ccf driver for IDT 8T49N24x UFT")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
 clk-idt8t49n24x-core.c    |    2 +-
 clk-idt8t49n24x-debugfs.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/idt/clk-idt8t49n24x-core.c b/drivers/clk/idt/clk-idt8t49n24x-core.c
index fb8f4db..5fce51e 100644
--- a/drivers/clk/idt/clk-idt8t49n24x-core.c
+++ b/drivers/clk/idt/clk-idt8t49n24x-core.c
@@ -47,7 +47,7 @@
 #define IDT24x_VCO_OPT			3500000000u
 #define IDT24x_MIN_INT_DIVIDER		6
 
-u8 q0_ns1_options[3] = { 4, 5, 6 };
+static u8 q0_ns1_options[3] = { 4, 5, 6 };
 
 /**
  * bits_to_shift - num bits to shift given specified mask
diff --git a/drivers/clk/idt/clk-idt8t49n24x-debugfs.c b/drivers/clk/idt/clk-idt8t49n24x-debugfs.c
index d8fcf4e..0b259cb 100644
--- a/drivers/clk/idt/clk-idt8t49n24x-debugfs.c
+++ b/drivers/clk/idt/clk-idt8t49n24x-debugfs.c
@@ -16,7 +16,7 @@
 
 #include "clk-idt8t49n24x-debugfs.h"
 
-struct clk_idt24x_chip *idt24x_chip_fordebugfs;
+static struct clk_idt24x_chip *idt24x_chip_fordebugfs;
 
 static int idt24x_read_all_settings(
 	struct clk_idt24x_chip *chip, char *output_buffer, int count)