From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net] net: phy: broadcom: Fix bcm_write_exp()
Date: Wed, 23 May 2018 02:15:03 +0200 [thread overview]
Message-ID: <20180523001503.GA16062@lunn.ch> (raw)
In-Reply-To: <20180523000450.9384-1-f.fainelli@gmail.com>
On Tue, May 22, 2018 at 05:04:49PM -0700, Florian Fainelli wrote:
> On newer PHYs, we need to select the expansion register to write with
> setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior
> to being migrated to generic code under bcm-phy-lib.c which
> unfortunately used the older implementation from the BCM54xx days.
Hi Florian
Does selecting the expansion register affect access to the standard
registers? Does this need locking like the Marvell PHY has when
changing pages?
Thanks
Andrew
next prev parent reply other threads:[~2018-05-23 0:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 0:04 [PATCH net] net: phy: broadcom: Fix bcm_write_exp() Florian Fainelli
2018-05-23 0:15 ` Andrew Lunn [this message]
2018-05-23 1:20 ` Florian Fainelli
2018-05-23 16:57 ` Florian Fainelli
2018-05-23 19:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523001503.GA16062@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox