public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mcpm, perf/arm-cci: export mcpm_is_available
Date: Tue, 29 May 2018 16:47:38 +0100	[thread overview]
Message-ID: <20180529154738.GL17159@arm.com> (raw)
In-Reply-To: <20180529154251.GM17671@n2100.armlinux.org.uk>

On Tue, May 29, 2018 at 04:42:51PM +0100, Russell King - ARM Linux wrote:
> On Tue, May 29, 2018 at 04:41:20PM +0100, Will Deacon wrote:
> > Hi Russell,
> > 
> > On Tue, May 29, 2018 at 04:33:24PM +0100, Russell King - ARM Linux wrote:
> > > On Tue, May 29, 2018 at 04:30:14PM +0100, Will Deacon wrote:
> > > > Hi Arnd, Russell, [+Nico and Robin]
> > > > 
> > > > On Mon, May 28, 2018 at 05:44:36PM +0200, Arnd Bergmann wrote:
> > > > > Now that the ARM CCI PMU driver can be built as a loadable module,
> > > > > we get a link failure when MCPM is enabled:
> > > > > 
> > > > > ERROR: "mcpm_is_available" [drivers/perf/arm-cci.ko] undefined!
> > > > > 
> > > > > The simplest fix is to export that helper function.
> > > > > 
> > > > > Fixes: 8b0c93c20ef7 ("perf/arm-cci: Allow building as a module")
> > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > > > ---
> > > > > The patch that caused this is currently part of the arm-perf/for-next/perf
> > > > > branch, it would be good to have the fix there as well.
> > > > > ---
> > > > >  arch/arm/common/mcpm_entry.c | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > I'm happy to take this via the arm perf tree if others are ok with that.
> > > > Alternatively, I can revert the offending commit if there are objections
> > > > to exporting the symbol.
> > > > 
> > > > Russell: do you any preference?
> > > 
> > > As it claims to fix 8b0c93c20ef7, which I don't have, I can't take this
> > > patch.  Do we know which tree has this?
> > 
> > Yes, sorry, it's in my for-next/perf branch:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/commit/?h=for-next/perf&id=8b0c93c20ef78f15d8b760964ff79bda7f68c610
> > 
> > which is now in -next.
> > 
> > I'm happy to take the mcpm patch on top with your ack, but if you have
> > conflicting changes (or would prefer not to export the symbol to modules)
> > then I can just revert the patch in my tree for now.
> 
> I have no changes to that file, so:
> 
> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>

Thanks, I've picked up the fix from Arnd with your Ack and will push out
this evening.

Will

  reply	other threads:[~2018-05-29 15:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-28 15:44 [PATCH] ARM: mcpm, perf/arm-cci: export mcpm_is_available Arnd Bergmann
2018-05-29 15:30 ` Will Deacon
2018-05-29 15:33   ` Russell King - ARM Linux
2018-05-29 15:41     ` Will Deacon
2018-05-29 15:42       ` Russell King - ARM Linux
2018-05-29 15:47         ` Will Deacon [this message]
2018-05-29 15:51   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529154738.GL17159@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox