From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@bootlin.com (Alexandre Belloni) Date: Thu, 31 May 2018 11:25:42 +0200 Subject: [PATCH v4] rtc: sun6i: Fix bit_idx value for clk_register_gate In-Reply-To: <20180530182744.27611-1-jagan@amarulasolutions.com> References: <20180530182744.27611-1-jagan@amarulasolutions.com> Message-ID: <20180531092542.GA2727@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 30/05/2018 23:57:44+0530, Jagan Teki wrote: > From: Michael Trimarchi > > clk-gate core will take bit_idx through clk_register_gate > and then do clk_gate_ops by using BIT(bit_idx), but rtc-sun6i > is passing bit_idx as BIT(bit_idx) it becomes BIT(BIT(bit_idx) > which is wrong and eventually external gate clock is not enabling. > > This patch fixed by passing bit index and the original change > introduced from below commit. > "rtc: sun6i: Add support for the external oscillator gate" > (sha1: 17ecd246414b3a0fe0cb248c86977a8bda465b7b) > > Signed-off-by: Michael Trimarchi > Fixes: 17ecd246414b ("rtc: sun6i: Add support for the external oscillator gate") > Cc: stable at vger.kernel.org > Signed-off-by: Jagan Teki > --- > Changes for v4: > - Cc to stable tree > Changes for v3: > - add fixes tag > - Cced stable ML > Changes for v2: > - add suffix _OFFSET with macro name to distinguish b/w > register actual values vs offset. > > drivers/rtc/rtc-sun6i.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com