From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation
Date: Tue, 19 Jun 2018 10:24:22 -0700 [thread overview]
Message-ID: <20180619172422.GB16846@roeck-us.net> (raw)
In-Reply-To: <CAKv+Gu-T8Fx3Nry7pUdOoOeRU-Ns89w3oo4itmu1q4FzYF5Rag@mail.gmail.com>
On Tue, Jun 19, 2018 at 03:35:07PM +0200, Ard Biesheuvel wrote:
> >>
> >> + /* this needs to be a separate macro or \@ does not work correctly
> >> */
> >> + .macro __badr, c, rd, sym
> >> + .eqv .Lsym\@, \sym
> >> + adr\c \rd, .Lsym\@ + 1
> >
> >
> > Wild shot, but the following works for me.
> >
> > .eqv .Lsym\@, \sym + 1
> > adr\c \rd, .Lsym\@
> >
> > Does it make sense ?
> >
>
> Interesting. Do you mean this works with your 2.30 binutils that
> triggers the original issue?
>
Yes, it does. It is also the solution used for some graphics libraries,
though of course now I don't find the link anymore.
Guess this is going nowhere given Russell's response, so I'll just
live with it, like obviously everyone else does already. I built
a toolchain using gcc 7.3.0 and binutils 2.28.1 which "solves"
the problem for me.
Guenter
next prev parent reply other threads:[~2018-06-19 17:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 5:07 [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation Guenter Roeck
2018-06-19 7:48 ` Ard Biesheuvel
2018-06-19 7:51 ` Ard Biesheuvel
2018-06-19 13:29 ` Guenter Roeck
2018-06-19 13:35 ` Ard Biesheuvel
2018-06-19 15:12 ` Russell King - ARM Linux
2018-06-19 17:14 ` Guenter Roeck
2018-06-19 18:08 ` Russell King - ARM Linux
2018-06-19 17:24 ` Guenter Roeck [this message]
2018-06-19 18:17 ` Ard Biesheuvel
2018-06-19 18:20 ` Ard Biesheuvel
2018-06-19 18:28 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619172422.GB16846@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox