linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: i2c: lm3560: add support for lm3559 chip
Date: Sat, 23 Jun 2018 23:33:28 +0200	[thread overview]
Message-ID: <20180623213328.GA19154@amd> (raw)
In-Reply-To: <20180506080607.GA24212@amd>

On Sun 2018-05-06 10:06:07, Pavel Machek wrote:
> 
> Add support for LM3559, as found in Motorola Droid 4 phone, for
> example. SW interface seems to be identical.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Ping?

Could this and media: i2c: lm3560: use conservative defaults be
applied for v4.19? This is not too complex...

								Pavel
								
> 
> diff --git a/drivers/media/i2c/lm3560.c b/drivers/media/i2c/lm3560.c
> index b600e03a..c4e5ed5 100644
> --- a/drivers/media/i2c/lm3560.c
> +++ b/drivers/media/i2c/lm3560.c
> @@ -1,6 +1,6 @@
>  /*
>   * drivers/media/i2c/lm3560.c
> - * General device driver for TI lm3560, FLASH LED Driver
> + * General device driver for TI lm3559, lm3560, FLASH LED Driver
>   *
>   * Copyright (C) 2013 Texas Instruments
>   *
> @@ -465,6 +479,7 @@ static int lm3560_remove(struct i2c_client *client)
>  }
>  
>  static const struct i2c_device_id lm3560_id_table[] = {
> +	{LM3559_NAME, 0},
>  	{LM3560_NAME, 0},
>  	{}
>  };
> diff --git a/include/media/i2c/lm3560.h b/include/media/i2c/lm3560.h
> index a5bd310..0e2b1c7 100644
> --- a/include/media/i2c/lm3560.h
> +++ b/include/media/i2c/lm3560.h
> @@ -22,6 +22,7 @@
>  
>  #include <media/v4l2-subdev.h>
>  
> +#define LM3559_NAME	"lm3559"
>  #define LM3560_NAME	"lm3560"
>  #define LM3560_I2C_ADDR	(0x53)
>  
> 



-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180623/0e179ed3/attachment.sig>

  reply	other threads:[~2018-06-23 21:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-06  8:06 [PATCH] media: i2c: lm3560: add support for lm3559 chip Pavel Machek
2018-06-23 21:33 ` Pavel Machek [this message]
2018-07-01 18:00   ` Daniel Jeong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180623213328.GA19154@amd \
    --to=pavel@ucw.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).