From: LW@KARO-electronics.de (Lothar Waßmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dt-bindings: serial: imx: clarify rs485 support usage
Date: Mon, 25 Jun 2018 10:16:38 +0200 [thread overview]
Message-ID: <20180625101638.47f3b3dd@karo-electronics.de> (raw)
In-Reply-To: <01fc1e3d89037adce38177c3922d277584214fdd.1529911999.git.baruch@tkos.co.il>
Hi,
On Mon, 25 Jun 2018 10:33:19 +0300 Baruch Siach wrote:
> The i.MX UART peripheral uses the RST_B signal as input, and CTS_B as
> output. This is just like the CDE role in RS-232. This is true
>
s/CDE/DCE/
> regardless of the "DTE mode" setting of this peripheral.
>
> As a result, rs485 support hardware must use the CTS_B signal to control
> the RS-485 transceiver. This is in contrast to generic rs485 kernel
> code, documentation, and DT property names that consistently refer to
> the RST as transceiver control signal.
>
s/RST/RTS/
> Add a note in the DT binding document about that, to reduce the
> confusion somewhat.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> Documentation/devicetree/bindings/serial/fsl-imx-uart.txt | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt b/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt
> index afcfbc34e243..35957cbf1571 100644
> --- a/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt
> +++ b/Documentation/devicetree/bindings/serial/fsl-imx-uart.txt
> @@ -9,7 +9,11 @@ Optional properties:
> - fsl,dte-mode : Indicate the uart works in DTE mode. The uart works
> in DCE mode by default.
> - rs485-rts-delay, rs485-rts-active-low, rs485-rx-during-tx,
> - linux,rs485-enabled-at-boot-time: see rs485.txt
> + linux,rs485-enabled-at-boot-time: see rs485.txt. Note that for RS485
> + you must enable either the "uart-has-rtscts" or the "rts-gpios"
> + properties. In case you use "uart-has-rtscts" the signal that controls
> + the transceiver is actually CTS_B, not RTS_B. CTS_B is always output,
> + and RTS_B is input, regardless of dte-mode.
>
> Please check Documentation/devicetree/bindings/serial/serial.txt
> for the complete list of generic properties.
Lothar Wa?mann
prev parent reply other threads:[~2018-06-25 8:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 7:33 [PATCH] dt-bindings: serial: imx: clarify rs485 support usage Baruch Siach
2018-06-25 8:16 ` Lothar Waßmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180625101638.47f3b3dd@karo-electronics.de \
--to=lw@karo-electronics.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).