* [PATCH 0/4] Add Actions Semi S900 SPS support
@ 2018-04-11 16:40 Manivannan Sadhasivam
2018-04-11 16:40 ` [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS Manivannan Sadhasivam
` (3 more replies)
0 siblings, 4 replies; 17+ messages in thread
From: Manivannan Sadhasivam @ 2018-04-11 16:40 UTC (permalink / raw)
To: linux-arm-kernel
Add SPS (Smart Power System) support to Actions Semi S900 SoC.
Manivannan Sadhasivam (4):
dt-bindings: power: Add Actions Semi S900 SPS
arm64: dts: actions: Add S900 SPS node
soc: actions: sps: Add S900 power domains
soc: actions: Fix help text in Kconfig for OWL_PM_DOMAINS
.../devicetree/bindings/power/actions,owl-sps.txt | 2 +
arch/arm64/boot/dts/actions/s900.dtsi | 6 +++
drivers/soc/actions/Kconfig | 2 +-
drivers/soc/actions/owl-sps.c | 58 ++++++++++++++++++++++
include/dt-bindings/power/owl-s900-powergate.h | 23 +++++++++
5 files changed, 90 insertions(+), 1 deletion(-)
create mode 100644 include/dt-bindings/power/owl-s900-powergate.h
--
2.14.1
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS 2018-04-11 16:40 [PATCH 0/4] Add Actions Semi S900 SPS support Manivannan Sadhasivam @ 2018-04-11 16:40 ` Manivannan Sadhasivam 2018-04-16 18:48 ` Rob Herring 2018-06-24 13:04 ` Andreas Färber 2018-04-11 16:40 ` [PATCH 2/4] arm64: dts: actions: Add S900 SPS node Manivannan Sadhasivam ` (2 subsequent siblings) 3 siblings, 2 replies; 17+ messages in thread From: Manivannan Sadhasivam @ 2018-04-11 16:40 UTC (permalink / raw) To: linux-arm-kernel Define power domains for Actions Semi S900 SoC Smart Power System (SPS). Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- .../devicetree/bindings/power/actions,owl-sps.txt | 2 ++ include/dt-bindings/power/owl-s900-powergate.h | 23 ++++++++++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 include/dt-bindings/power/owl-s900-powergate.h diff --git a/Documentation/devicetree/bindings/power/actions,owl-sps.txt b/Documentation/devicetree/bindings/power/actions,owl-sps.txt index 78edd63641e8..a3571937b019 100644 --- a/Documentation/devicetree/bindings/power/actions,owl-sps.txt +++ b/Documentation/devicetree/bindings/power/actions,owl-sps.txt @@ -3,11 +3,13 @@ Actions Semi Owl Smart Power System (SPS) Required properties: - compatible : "actions,s500-sps" for S500 "actions,s700-sps" for S700 + "actions,s900-sps" for S900 - reg : Offset and length of the register set for the device. - #power-domain-cells : Must be 1. See macros in: include/dt-bindings/power/owl-s500-powergate.h for S500 include/dt-bindings/power/owl-s700-powergate.h for S700 + include/dt-bindings/power/owl-s900-powergate.h for S900 Example: diff --git a/include/dt-bindings/power/owl-s900-powergate.h b/include/dt-bindings/power/owl-s900-powergate.h new file mode 100644 index 000000000000..f1aaf761112b --- /dev/null +++ b/include/dt-bindings/power/owl-s900-powergate.h @@ -0,0 +1,23 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * Actions Semi S900 SPS + * + * Copyright (c) 2018 Linaro Ltd. + */ +#ifndef DT_BINDINGS_POWER_OWL_S900_POWERGATE_H +#define DT_BINDINGS_POWER_OWL_S900_POWERGATE_H + +#define S900_PD_GPU_B 0 +#define S900_PD_VCE 1 +#define S900_PD_SENSOR 2 +#define S900_PD_VDE 3 +#define S900_PD_HDE 4 +#define S900_PD_USB3 5 +#define S900_PD_DDR0 6 +#define S900_PD_DDR1 7 +#define S900_PD_DE 8 +#define S900_PD_NAND 9 +#define S900_PD_USB2_H0 10 +#define S900_PD_USB2_H1 11 + +#endif -- 2.14.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS 2018-04-11 16:40 ` [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS Manivannan Sadhasivam @ 2018-04-16 18:48 ` Rob Herring 2018-06-24 13:04 ` Andreas Färber 1 sibling, 0 replies; 17+ messages in thread From: Rob Herring @ 2018-04-16 18:48 UTC (permalink / raw) To: linux-arm-kernel On Wed, Apr 11, 2018 at 10:10:33PM +0530, Manivannan Sadhasivam wrote: > Define power domains for Actions Semi S900 SoC Smart Power System (SPS). > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > .../devicetree/bindings/power/actions,owl-sps.txt | 2 ++ > include/dt-bindings/power/owl-s900-powergate.h | 23 ++++++++++++++++++++++ > 2 files changed, 25 insertions(+) > create mode 100644 include/dt-bindings/power/owl-s900-powergate.h Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS 2018-04-11 16:40 ` [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS Manivannan Sadhasivam 2018-04-16 18:48 ` Rob Herring @ 2018-06-24 13:04 ` Andreas Färber 2018-06-26 16:41 ` Manivannan Sadhasivam 1 sibling, 1 reply; 17+ messages in thread From: Andreas Färber @ 2018-06-24 13:04 UTC (permalink / raw) To: linux-arm-kernel Hi Mani, Am 11.04.2018 um 18:40 schrieb Manivannan Sadhasivam: > Define power domains for Actions Semi S900 SoC Smart Power System (SPS). > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > .../devicetree/bindings/power/actions,owl-sps.txt | 2 ++ > include/dt-bindings/power/owl-s900-powergate.h | 23 ++++++++++++++++++++++ > 2 files changed, 25 insertions(+) > create mode 100644 include/dt-bindings/power/owl-s900-powergate.h > > diff --git a/Documentation/devicetree/bindings/power/actions,owl-sps.txt b/Documentation/devicetree/bindings/power/actions,owl-sps.txt > index 78edd63641e8..a3571937b019 100644 > --- a/Documentation/devicetree/bindings/power/actions,owl-sps.txt > +++ b/Documentation/devicetree/bindings/power/actions,owl-sps.txt > @@ -3,11 +3,13 @@ Actions Semi Owl Smart Power System (SPS) > Required properties: > - compatible : "actions,s500-sps" for S500 > "actions,s700-sps" for S700 > + "actions,s900-sps" for S900 > - reg : Offset and length of the register set for the device. > - #power-domain-cells : Must be 1. > See macros in: > include/dt-bindings/power/owl-s500-powergate.h for S500 > include/dt-bindings/power/owl-s700-powergate.h for S700 > + include/dt-bindings/power/owl-s900-powergate.h for S900 > > > Example: > diff --git a/include/dt-bindings/power/owl-s900-powergate.h b/include/dt-bindings/power/owl-s900-powergate.h > new file mode 100644 > index 000000000000..f1aaf761112b > --- /dev/null > +++ b/include/dt-bindings/power/owl-s900-powergate.h > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: GPL-2.0+ checkpatch.pl warns about this line due to not using /* ... */ syntax for headers. I could fix that up on my own, but it made me realize that you are licensing this file under GPL-2.0+ only, whereas the .dts[i] is supposed to be dual-licensed. Can you please give your consent to make this /* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ like my S500 and S700 bindings? Question: Should it still be GPL-2.0+ or the new GPL-2.0-or-later? Otherwise looks fine, except that I'll need a topic branch (v4.19/s900-sps-bindings) if we want to merge the driver portion at the same time. Regards, Andreas > +/* > + * Actions Semi S900 SPS > + * > + * Copyright (c) 2018 Linaro Ltd. > + */ > +#ifndef DT_BINDINGS_POWER_OWL_S900_POWERGATE_H > +#define DT_BINDINGS_POWER_OWL_S900_POWERGATE_H > + > +#define S900_PD_GPU_B 0 > +#define S900_PD_VCE 1 > +#define S900_PD_SENSOR 2 > +#define S900_PD_VDE 3 > +#define S900_PD_HDE 4 > +#define S900_PD_USB3 5 > +#define S900_PD_DDR0 6 > +#define S900_PD_DDR1 7 > +#define S900_PD_DE 8 > +#define S900_PD_NAND 9 > +#define S900_PD_USB2_H0 10 > +#define S900_PD_USB2_H1 11 > + > +#endif > -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS 2018-06-24 13:04 ` Andreas Färber @ 2018-06-26 16:41 ` Manivannan Sadhasivam 2018-06-27 14:57 ` Daniel Thompson 0 siblings, 1 reply; 17+ messages in thread From: Manivannan Sadhasivam @ 2018-06-26 16:41 UTC (permalink / raw) To: linux-arm-kernel Hi Andreas, On Sun, Jun 24, 2018 at 03:04:21PM +0200, Andreas F?rber wrote: > Hi Mani, > > Am 11.04.2018 um 18:40 schrieb Manivannan Sadhasivam: > > Define power domains for Actions Semi S900 SoC Smart Power System (SPS). > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > .../devicetree/bindings/power/actions,owl-sps.txt | 2 ++ > > include/dt-bindings/power/owl-s900-powergate.h | 23 ++++++++++++++++++++++ > > 2 files changed, 25 insertions(+) > > create mode 100644 include/dt-bindings/power/owl-s900-powergate.h > > > > diff --git a/Documentation/devicetree/bindings/power/actions,owl-sps.txt b/Documentation/devicetree/bindings/power/actions,owl-sps.txt > > index 78edd63641e8..a3571937b019 100644 > > --- a/Documentation/devicetree/bindings/power/actions,owl-sps.txt > > +++ b/Documentation/devicetree/bindings/power/actions,owl-sps.txt > > @@ -3,11 +3,13 @@ Actions Semi Owl Smart Power System (SPS) > > Required properties: > > - compatible : "actions,s500-sps" for S500 > > "actions,s700-sps" for S700 > > + "actions,s900-sps" for S900 > > - reg : Offset and length of the register set for the device. > > - #power-domain-cells : Must be 1. > > See macros in: > > include/dt-bindings/power/owl-s500-powergate.h for S500 > > include/dt-bindings/power/owl-s700-powergate.h for S700 > > + include/dt-bindings/power/owl-s900-powergate.h for S900 > > > > > > Example: > > diff --git a/include/dt-bindings/power/owl-s900-powergate.h b/include/dt-bindings/power/owl-s900-powergate.h > > new file mode 100644 > > index 000000000000..f1aaf761112b > > --- /dev/null > > +++ b/include/dt-bindings/power/owl-s900-powergate.h > > @@ -0,0 +1,23 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > checkpatch.pl warns about this line due to not using /* ... */ syntax > for headers. I could fix that up on my own, but it made me realize that > you are licensing this file under GPL-2.0+ only, whereas the .dts[i] is > supposed to be dual-licensed. > > Can you please give your consent to make this > > /* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > You can change the license to GPL-2.0+ OR MIT. > like my S500 and S700 bindings? > > Question: Should it still be GPL-2.0+ or the new GPL-2.0-or-later? > I think GPL-2.0+ is fine. Thanks, Mani > Otherwise looks fine, except that I'll need a topic branch > (v4.19/s900-sps-bindings) if we want to merge the driver portion at the > same time. > > Regards, > Andreas > > > +/* > > + * Actions Semi S900 SPS > > + * > > + * Copyright (c) 2018 Linaro Ltd. > > + */ > > +#ifndef DT_BINDINGS_POWER_OWL_S900_POWERGATE_H > > +#define DT_BINDINGS_POWER_OWL_S900_POWERGATE_H > > + > > +#define S900_PD_GPU_B 0 > > +#define S900_PD_VCE 1 > > +#define S900_PD_SENSOR 2 > > +#define S900_PD_VDE 3 > > +#define S900_PD_HDE 4 > > +#define S900_PD_USB3 5 > > +#define S900_PD_DDR0 6 > > +#define S900_PD_DDR1 7 > > +#define S900_PD_DE 8 > > +#define S900_PD_NAND 9 > > +#define S900_PD_USB2_H0 10 > > +#define S900_PD_USB2_H1 11 > > + > > +#endif > > > > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany > GF: Felix Imend?rffer, Jane Smithard, Graham Norton > HRB 21284 (AG N?rnberg) ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS 2018-06-26 16:41 ` Manivannan Sadhasivam @ 2018-06-27 14:57 ` Daniel Thompson 2018-06-27 15:05 ` Andreas Färber 2018-06-27 15:10 ` Manivannan Sadhasivam 0 siblings, 2 replies; 17+ messages in thread From: Daniel Thompson @ 2018-06-27 14:57 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jun 26, 2018 at 10:11:17PM +0530, Manivannan Sadhasivam wrote: > > > diff --git a/include/dt-bindings/power/owl-s900-powergate.h b/include/dt-bindings/power/owl-s900-powergate.h > > > new file mode 100644 > > > index 000000000000..f1aaf761112b > > > --- /dev/null > > > +++ b/include/dt-bindings/power/owl-s900-powergate.h > > > @@ -0,0 +1,23 @@ > > > +// SPDX-License-Identifier: GPL-2.0+ > > > > checkpatch.pl warns about this line due to not using /* ... */ syntax > > for headers. I could fix that up on my own, but it made me realize that > > you are licensing this file under GPL-2.0+ only, whereas the .dts[i] is > > supposed to be dual-licensed. > > > > Can you please give your consent to make this > > > > /* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > > > > You can change the license to GPL-2.0+ OR MIT. > > > like my S500 and S700 bindings? > > > > Question: Should it still be GPL-2.0+ or the new GPL-2.0-or-later? > > > > I think GPL-2.0+ is fine. So... when I saw this I did wonder why one would knowly choose to use a deprecated license identifier (https://spdx.org/licenses/ ). However running `git diff v4.17..v4.18-rc1` through some filters does indicate that GPL-2.0+ is the more popular choice by 256 to 0! Doesn't mean you couldn't break the mould though ;-). Daniel. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS 2018-06-27 14:57 ` Daniel Thompson @ 2018-06-27 15:05 ` Andreas Färber 2018-06-27 15:10 ` Manivannan Sadhasivam 1 sibling, 0 replies; 17+ messages in thread From: Andreas Färber @ 2018-06-27 15:05 UTC (permalink / raw) To: linux-arm-kernel Am 27.06.2018 um 16:57 schrieb Daniel Thompson: > On Tue, Jun 26, 2018 at 10:11:17PM +0530, Manivannan Sadhasivam wrote: >>> Question: Should it still be GPL-2.0+ or the new GPL-2.0-or-later? >> >> I think GPL-2.0+ is fine. > > So... when I saw this I did wonder why one would knowly choose to use a > deprecated license identifier (https://spdx.org/licenses/ ). > > However running `git diff v4.17..v4.18-rc1` through some filters does > indicate that GPL-2.0+ is the more popular choice by 256 to 0! Doesn't > mean you couldn't break the mould though ;-). The kernel.org documentation does not mention the new ones yet. I checked under LICENSES/ - preferred/GPL-2.0.txt actually lists both identifiers, and checkpatch.pl did not complain about either. So for my personal patches I'll be going with the new identifier, unless I hear of reasons not to. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS 2018-06-27 14:57 ` Daniel Thompson 2018-06-27 15:05 ` Andreas Färber @ 2018-06-27 15:10 ` Manivannan Sadhasivam 1 sibling, 0 replies; 17+ messages in thread From: Manivannan Sadhasivam @ 2018-06-27 15:10 UTC (permalink / raw) To: linux-arm-kernel On Wed, Jun 27, 2018 at 03:57:13PM +0100, Daniel Thompson wrote: > On Tue, Jun 26, 2018 at 10:11:17PM +0530, Manivannan Sadhasivam wrote: > > > > diff --git a/include/dt-bindings/power/owl-s900-powergate.h b/include/dt-bindings/power/owl-s900-powergate.h > > > > new file mode 100644 > > > > index 000000000000..f1aaf761112b > > > > --- /dev/null > > > > +++ b/include/dt-bindings/power/owl-s900-powergate.h > > > > @@ -0,0 +1,23 @@ > > > > +// SPDX-License-Identifier: GPL-2.0+ > > > > > > checkpatch.pl warns about this line due to not using /* ... */ syntax > > > for headers. I could fix that up on my own, but it made me realize that > > > you are licensing this file under GPL-2.0+ only, whereas the .dts[i] is > > > supposed to be dual-licensed. > > > > > > Can you please give your consent to make this > > > > > > /* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */ > > > > > > > You can change the license to GPL-2.0+ OR MIT. > > > > > like my S500 and S700 bindings? > > > > > > Question: Should it still be GPL-2.0+ or the new GPL-2.0-or-later? > > > > > > > I think GPL-2.0+ is fine. > > So... when I saw this I did wonder why one would knowly choose to use a > deprecated license identifier (https://spdx.org/licenses/ ). > > However running `git diff v4.17..v4.18-rc1` through some filters does > indicate that GPL-2.0+ is the more popular choice by 256 to 0! Doesn't > mean you couldn't break the mould though ;-). > I did grep through the source and hit with same numbers ;-) But I was not sure whether to break the mould or not, so chose the safest path :) Since you already gave the green signal, I think we can move to new style identifier. Thanks, Mani > > Daniel. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 2/4] arm64: dts: actions: Add S900 SPS node 2018-04-11 16:40 [PATCH 0/4] Add Actions Semi S900 SPS support Manivannan Sadhasivam 2018-04-11 16:40 ` [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS Manivannan Sadhasivam @ 2018-04-11 16:40 ` Manivannan Sadhasivam 2018-06-24 13:06 ` Andreas Färber 2018-04-11 16:40 ` [PATCH 3/4] soc: actions: sps: Add S900 power domains Manivannan Sadhasivam 2018-04-11 16:40 ` [PATCH 4/4] soc: actions: Fix help text in Kconfig for OWL_PM_DOMAINS Manivannan Sadhasivam 3 siblings, 1 reply; 17+ messages in thread From: Manivannan Sadhasivam @ 2018-04-11 16:40 UTC (permalink / raw) To: linux-arm-kernel Add Actions Semi S900 Smart Power System (SPS) node Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- arch/arm64/boot/dts/actions/s900.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900.dtsi index 11406f6d3a6d..0b29dbe0030e 100644 --- a/arch/arm64/boot/dts/actions/s900.dtsi +++ b/arch/arm64/boot/dts/actions/s900.dtsi @@ -154,6 +154,12 @@ status = "disabled"; }; + sps: power-controller at e012e000 { + compatible = "actions,s900-sps"; + reg = <0x0 0xe012e000 0x0 0x2000>; + #power-domain-cells = <1>; + }; + timer: timer at e0228000 { compatible = "actions,s900-timer"; reg = <0x0 0xe0228000 0x0 0x8000>; -- 2.14.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 2/4] arm64: dts: actions: Add S900 SPS node 2018-04-11 16:40 ` [PATCH 2/4] arm64: dts: actions: Add S900 SPS node Manivannan Sadhasivam @ 2018-06-24 13:06 ` Andreas Färber 0 siblings, 0 replies; 17+ messages in thread From: Andreas Färber @ 2018-06-24 13:06 UTC (permalink / raw) To: linux-arm-kernel Am 11.04.2018 um 18:40 schrieb Manivannan Sadhasivam: > Add Actions Semi S900 Smart Power System (SPS) node > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > arch/arm64/boot/dts/actions/s900.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Andreas F?rber <afaerber@suse.de> (Depends on preceding bindings patch.) Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 3/4] soc: actions: sps: Add S900 power domains 2018-04-11 16:40 [PATCH 0/4] Add Actions Semi S900 SPS support Manivannan Sadhasivam 2018-04-11 16:40 ` [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS Manivannan Sadhasivam 2018-04-11 16:40 ` [PATCH 2/4] arm64: dts: actions: Add S900 SPS node Manivannan Sadhasivam @ 2018-04-11 16:40 ` Manivannan Sadhasivam 2018-06-24 13:07 ` Andreas Färber 2018-04-11 16:40 ` [PATCH 4/4] soc: actions: Fix help text in Kconfig for OWL_PM_DOMAINS Manivannan Sadhasivam 3 siblings, 1 reply; 17+ messages in thread From: Manivannan Sadhasivam @ 2018-04-11 16:40 UTC (permalink / raw) To: linux-arm-kernel Add power domains for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- drivers/soc/actions/owl-sps.c | 58 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/drivers/soc/actions/owl-sps.c b/drivers/soc/actions/owl-sps.c index 38b276e6f319..f6445d671f22 100644 --- a/drivers/soc/actions/owl-sps.c +++ b/drivers/soc/actions/owl-sps.c @@ -14,6 +14,7 @@ #include <linux/soc/actions/owl-sps.h> #include <dt-bindings/power/owl-s500-powergate.h> #include <dt-bindings/power/owl-s700-powergate.h> +#include <dt-bindings/power/owl-s900-powergate.h> struct owl_sps_domain_info { const char *name; @@ -240,9 +241,66 @@ static const struct owl_sps_info s700_sps_info = { .domains = s700_sps_domains, }; +static const struct owl_sps_domain_info s900_sps_domains[] = { + [S900_PD_GPU_B] = { + .name = "GPU_B", + .pwr_bit = 3, + }, + [S900_PD_VCE] = { + .name = "VCE", + .pwr_bit = 4, + }, + [S900_PD_SENSOR] = { + .name = "SENSOR", + .pwr_bit = 5, + }, + [S900_PD_VDE] = { + .name = "VDE", + .pwr_bit = 6, + }, + [S900_PD_HDE] = { + .name = "HDE", + .pwr_bit = 7, + }, + [S900_PD_USB3] = { + .name = "USB3", + .pwr_bit = 8, + }, + [S900_PD_DDR0] = { + .name = "DDR0", + .pwr_bit = 9, + }, + [S900_PD_DDR1] = { + .name = "DDR1", + .pwr_bit = 10, + }, + [S900_PD_DE] = { + .name = "DE", + .pwr_bit = 13, + }, + [S900_PD_NAND] = { + .name = "NAND", + .pwr_bit = 14, + }, + [S900_PD_USB2_H0] = { + .name = "USB2_H0", + .pwr_bit = 15, + }, + [S900_PD_USB2_H1] = { + .name = "USB2_H1", + .pwr_bit = 16, + }, +}; + +static const struct owl_sps_info s900_sps_info = { + .num_domains = ARRAY_SIZE(s900_sps_domains), + .domains = s900_sps_domains, +}; + static const struct of_device_id owl_sps_of_matches[] = { { .compatible = "actions,s500-sps", .data = &s500_sps_info }, { .compatible = "actions,s700-sps", .data = &s700_sps_info }, + { .compatible = "actions,s900-sps", .data = &s900_sps_info }, { } }; -- 2.14.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 3/4] soc: actions: sps: Add S900 power domains 2018-04-11 16:40 ` [PATCH 3/4] soc: actions: sps: Add S900 power domains Manivannan Sadhasivam @ 2018-06-24 13:07 ` Andreas Färber 2018-09-30 15:46 ` Andreas Färber 0 siblings, 1 reply; 17+ messages in thread From: Andreas Färber @ 2018-06-24 13:07 UTC (permalink / raw) To: linux-arm-kernel Am 11.04.2018 um 18:40 schrieb Manivannan Sadhasivam: > Add power domains for Actions Semi S900 SoC. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/soc/actions/owl-sps.c | 58 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) Reviewed-by: Andreas F?rber <afaerber@suse.de> (Depends on bindings patch.) Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 3/4] soc: actions: sps: Add S900 power domains 2018-06-24 13:07 ` Andreas Färber @ 2018-09-30 15:46 ` Andreas Färber 0 siblings, 0 replies; 17+ messages in thread From: Andreas Färber @ 2018-09-30 15:46 UTC (permalink / raw) To: linux-arm-kernel Am 24.06.18 um 15:07 schrieb Andreas F?rber: > Am 11.04.2018 um 18:40 schrieb Manivannan Sadhasivam: >> Add power domains for Actions Semi S900 SoC. >> >> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >> --- >> drivers/soc/actions/owl-sps.c | 58 +++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 58 insertions(+) > > Reviewed-by: Andreas F?rber <afaerber@suse.de> Series merged now via topic branch. Thanks, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 4/4] soc: actions: Fix help text in Kconfig for OWL_PM_DOMAINS 2018-04-11 16:40 [PATCH 0/4] Add Actions Semi S900 SPS support Manivannan Sadhasivam ` (2 preceding siblings ...) 2018-04-11 16:40 ` [PATCH 3/4] soc: actions: sps: Add S900 power domains Manivannan Sadhasivam @ 2018-04-11 16:40 ` Manivannan Sadhasivam 2018-06-24 13:28 ` Andreas Färber 3 siblings, 1 reply; 17+ messages in thread From: Manivannan Sadhasivam @ 2018-04-11 16:40 UTC (permalink / raw) To: linux-arm-kernel OWL_PM_DOMAINS is being used by 3 SoCs of OWL family. This fixes the wording to use family name OWL instead of SoC name S500. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- drivers/soc/actions/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/actions/Kconfig b/drivers/soc/actions/Kconfig index 9d68b5a771c3..26c3155d3738 100644 --- a/drivers/soc/actions/Kconfig +++ b/drivers/soc/actions/Kconfig @@ -10,7 +10,7 @@ config OWL_PM_DOMAINS select PM_GENERIC_DOMAINS help Say 'y' here to enable support for Smart Power System (SPS) - power-gating on Actions Semiconductor S500 SoC. + power-gating on Actions Semiconductor OWL SoCs. If unsure, say 'n'. endif -- 2.14.1 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH 4/4] soc: actions: Fix help text in Kconfig for OWL_PM_DOMAINS 2018-04-11 16:40 ` [PATCH 4/4] soc: actions: Fix help text in Kconfig for OWL_PM_DOMAINS Manivannan Sadhasivam @ 2018-06-24 13:28 ` Andreas Färber 2018-06-24 14:01 ` [PATCH] soc: actions: Update SPS help text for S700 Andreas Färber 0 siblings, 1 reply; 17+ messages in thread From: Andreas Färber @ 2018-06-24 13:28 UTC (permalink / raw) To: linux-arm-kernel Hi Mani, Am 11.04.2018 um 18:40 schrieb Manivannan Sadhasivam: > OWL_PM_DOMAINS is being used by 3 SoCs of OWL family. This fixes > the wording to use family name OWL instead of SoC name S500. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/soc/actions/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/actions/Kconfig b/drivers/soc/actions/Kconfig > index 9d68b5a771c3..26c3155d3738 100644 > --- a/drivers/soc/actions/Kconfig > +++ b/drivers/soc/actions/Kconfig > @@ -10,7 +10,7 @@ config OWL_PM_DOMAINS > select PM_GENERIC_DOMAINS > help > Say 'y' here to enable support for Smart Power System (SPS) > - power-gating on Actions Semiconductor S500 SoC. > + power-gating on Actions Semiconductor OWL SoCs. Thanks for spotting this. However, repeating OWL from the title (which I think should be spelled Owl in free text, given that I also read Falcon as another bird for GT9 [*]) does not seem too helpful for people wondering whether or not to enable the driver. I would much rather do a patch updating this to "S500 and S700 SoCs" with Fixes and then just add S900 as part of your preceding patch. Regards, Andreas [*] https://androidpc.es/blog/2015/11/10/actions-gt7/ > If unsure, say 'n'. > > endif > -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH] soc: actions: Update SPS help text for S700 2018-06-24 13:28 ` Andreas Färber @ 2018-06-24 14:01 ` Andreas Färber 2018-09-22 20:11 ` Andreas Färber 0 siblings, 1 reply; 17+ messages in thread From: Andreas Färber @ 2018-06-24 14:01 UTC (permalink / raw) To: linux-arm-kernel Commit 3ad85b08f7789d51e6aad0f535296d1c31e319b9 (soc: actions: sps: Add S700) added S700 support to the SPS driver but forget to update Kconfig help. Add missing S700 mention, in preparation for further SoCs. Fixes: 3ad85b08f778 ("soc: actions: sps: Add S700") Reported-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Signed-off-by: Andreas F?rber <afaerber@suse.de> --- drivers/soc/actions/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/actions/Kconfig b/drivers/soc/actions/Kconfig index 9d68b5a771c3..56064f8859a0 100644 --- a/drivers/soc/actions/Kconfig +++ b/drivers/soc/actions/Kconfig @@ -10,7 +10,7 @@ config OWL_PM_DOMAINS select PM_GENERIC_DOMAINS help Say 'y' here to enable support for Smart Power System (SPS) - power-gating on Actions Semiconductor S500 SoC. + power-gating on Actions Semiconductor S500 and S700 SoCs. If unsure, say 'n'. endif -- 2.16.4 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH] soc: actions: Update SPS help text for S700 2018-06-24 14:01 ` [PATCH] soc: actions: Update SPS help text for S700 Andreas Färber @ 2018-09-22 20:11 ` Andreas Färber 0 siblings, 0 replies; 17+ messages in thread From: Andreas Färber @ 2018-09-22 20:11 UTC (permalink / raw) To: linux-arm-kernel Am 24.06.18 um 16:01 schrieb Andreas F?rber: > Commit 3ad85b08f7789d51e6aad0f535296d1c31e319b9 (soc: actions: sps: Add S700) > added S700 support to the SPS driver but forget to update Kconfig help. > > Add missing S700 mention, in preparation for further SoCs. > > Fixes: 3ad85b08f778 ("soc: actions: sps: Add S700") > Reported-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Signed-off-by: Andreas F?rber <afaerber@suse.de> > --- > drivers/soc/actions/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to v4.20/drivers branch. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg) ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2018-09-30 15:46 UTC | newest] Thread overview: 17+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-04-11 16:40 [PATCH 0/4] Add Actions Semi S900 SPS support Manivannan Sadhasivam 2018-04-11 16:40 ` [PATCH 1/4] dt-bindings: power: Add Actions Semi S900 SPS Manivannan Sadhasivam 2018-04-16 18:48 ` Rob Herring 2018-06-24 13:04 ` Andreas Färber 2018-06-26 16:41 ` Manivannan Sadhasivam 2018-06-27 14:57 ` Daniel Thompson 2018-06-27 15:05 ` Andreas Färber 2018-06-27 15:10 ` Manivannan Sadhasivam 2018-04-11 16:40 ` [PATCH 2/4] arm64: dts: actions: Add S900 SPS node Manivannan Sadhasivam 2018-06-24 13:06 ` Andreas Färber 2018-04-11 16:40 ` [PATCH 3/4] soc: actions: sps: Add S900 power domains Manivannan Sadhasivam 2018-06-24 13:07 ` Andreas Färber 2018-09-30 15:46 ` Andreas Färber 2018-04-11 16:40 ` [PATCH 4/4] soc: actions: Fix help text in Kconfig for OWL_PM_DOMAINS Manivannan Sadhasivam 2018-06-24 13:28 ` Andreas Färber 2018-06-24 14:01 ` [PATCH] soc: actions: Update SPS help text for S700 Andreas Färber 2018-09-22 20:11 ` Andreas Färber
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).